Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1313533003: Fix some extern usage in .cc files. (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, yusukes+watch_chromium.org, jam, creis+watch_chromium.org, nasko+codewatch_chromium.org, shuchen+watch_chromium.org, rickyz+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, kalyank, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some extern usage in .cc files. Committed: https://crrev.com/5a551c4cbd70762d490e81c15c40fc79f19e5845 Cr-Commit-Position: refs/heads/master@{#346304}

Patch Set 1 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -59 lines) Patch
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 3 chunks +12 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api_constants.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/ash/chrome_launcher_prefs.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main.h View 1 chunk +0 lines, -2 lines 2 comments Download
M content/browser/browser_main_runner.cc View 4 chunks +10 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/common/sandbox_init_mac.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/common/sandbox_init_mac.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/public/browser/browser_main_runner.h View 1 chunk +3 lines, -0 lines 2 comments Download
M content/public/common/content_switches.cc View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Lei Zhang
https://codereview.chromium.org/1313533003/diff/40001/content/browser/browser_main.h File content/browser/browser_main.h (left): https://codereview.chromium.org/1313533003/diff/40001/content/browser/browser_main.h#oldcode15 content/browser/browser_main.h:15: bool ExitedMainMessageLoop(); marshall: You left this dangling in r121454 ...
5 years, 3 months ago (2015-08-28 06:45:41 UTC) #4
Marshall
https://codereview.chromium.org/1313533003/diff/40001/content/browser/browser_main.h File content/browser/browser_main.h (left): https://codereview.chromium.org/1313533003/diff/40001/content/browser/browser_main.h#oldcode15 content/browser/browser_main.h:15: bool ExitedMainMessageLoop(); On 2015/08/28 06:45:40, Lei Zhang wrote: > ...
5 years, 3 months ago (2015-08-28 16:11:21 UTC) #5
Lei Zhang
+nick for content/OWNERS
5 years, 3 months ago (2015-08-28 20:51:49 UTC) #7
ncarter (slow)
https://codereview.chromium.org/1313533003/diff/40001/content/public/browser/browser_main_runner.h File content/public/browser/browser_main_runner.h (right): https://codereview.chromium.org/1313533003/diff/40001/content/public/browser/browser_main_runner.h#newcode24 content/public/browser/browser_main_runner.h:24: static bool ExitedMainMessageLoop(); Does this need to be exposed ...
5 years, 3 months ago (2015-08-28 21:27:20 UTC) #8
Lei Zhang
https://codereview.chromium.org/1313533003/diff/40001/content/public/browser/browser_main_runner.h File content/public/browser/browser_main_runner.h (right): https://codereview.chromium.org/1313533003/diff/40001/content/public/browser/browser_main_runner.h#newcode24 content/public/browser/browser_main_runner.h:24: static bool ExitedMainMessageLoop(); On 2015/08/28 21:27:20, ncarter wrote: > ...
5 years, 3 months ago (2015-08-28 22:36:21 UTC) #9
ncarter (slow)
lgtm
5 years, 3 months ago (2015-08-29 00:06:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313533003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313533003/40001
5 years, 3 months ago (2015-08-29 00:23:30 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 3 months ago (2015-08-29 02:45:45 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-08-29 02:46:38 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5a551c4cbd70762d490e81c15c40fc79f19e5845
Cr-Commit-Position: refs/heads/master@{#346304}

Powered by Google App Engine
This is Rietveld 408576698