Chromium Code Reviews

Issue 1313513003: [heap] Enforce coding style decl order in {Heap} round #2. (Closed)

Created:
5 years, 4 months ago by Michael Lippautz
Modified:
5 years, 4 months ago
Reviewers:
Hannes Payer (out of office), Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Enforce coding style decl order in {Heap} round #2. BUG= Committed: https://crrev.com/e4d6f1dec101b6a148420c4e3e9330536de6ae9e Cr-Commit-Position: refs/heads/master@{#30344}

Patch Set 1 #

Total comments: 18

Patch Set 2 : addressed comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Stats (+110 lines, -99 lines)
M src/heap/heap.h View 17 chunks +104 lines, -93 lines 0 comments
M src/heap/heap.cc View 1 chunk +6 lines, -0 lines 0 comments
M src/heap/heap-inl.h View 1 chunk +0 lines, -6 lines 0 comments

Messages

Total messages: 11 (3 generated)
Michael Lippautz
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h File src/heap/heap-inl.h (left): https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h#oldcode326 src/heap/heap-inl.h:326: void Heap::PrintAlloctionsHash() { Any reason this debug method using ...
5 years, 4 months ago (2015-08-24 16:36:36 UTC) #2
Hannes Payer (out of office)
Cool, a ton of more work left... https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h File src/heap/heap-inl.h (left): https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h#oldcode326 src/heap/heap-inl.h:326: void Heap::PrintAlloctionsHash() ...
5 years, 4 months ago (2015-08-24 16:43:53 UTC) #3
Michael Starzinger
Nice. I love it. LGTM. https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h File src/heap/heap-inl.h (left): https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h#oldcode326 src/heap/heap-inl.h:326: void Heap::PrintAlloctionsHash() { On ...
5 years, 4 months ago (2015-08-24 16:55:47 UTC) #4
Michael Lippautz
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h File src/heap/heap-inl.h (left): https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h#oldcode326 src/heap/heap-inl.h:326: void Heap::PrintAlloctionsHash() { On 2015/08/24 16:55:47, Michael Starzinger wrote: ...
5 years, 4 months ago (2015-08-25 06:54:42 UTC) #5
Hannes Payer (out of office)
lgtm
5 years, 4 months ago (2015-08-25 07:35:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313513003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313513003/40001
5 years, 4 months ago (2015-08-25 07:47:58 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-25 08:24:10 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 08:24:20 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e4d6f1dec101b6a148420c4e3e9330536de6ae9e
Cr-Commit-Position: refs/heads/master@{#30344}

Powered by Google App Engine