[heap] Enforce coding style decl order in {Heap} round #2.

[heap] Enforce coding style decl order in {Heap} round #2.

BUG=

Committed: https://crrev.com/e4d6f1dec101b6a148420c4e3e9330536de6ae9e
Cr-Commit-Position: refs/heads/master@{#30344}

[Michael Lippautz, 2015-08-24 16:36:36]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org, mstarzinger@chromium.org

[Michael Lippautz, 2015-08-24 16:36:36]

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h
File src/heap/heap-inl.h (left):

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h#oldcode326
src/heap/heap-inl.h:326: void Heap::PrintAlloctionsHash() {
Any reason this debug method using prints is inlined?

[Hannes Payer (out of office), 2015-08-24 16:43:53]

Cool, a ton of more work left...

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h
File src/heap/heap-inl.h (left):

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h#oldcode326
src/heap/heap-inl.h:326: void Heap::PrintAlloctionsHash() {
On 2015/08/24 16:36:36, Michael Lippautz wrote:
> Any reason this debug method using prints is inlined?

Be gone.

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1047
src/heap/heap.h:1047: intptr_t CalculateOldGenerationAllocationLimit(double
factor,
CalculateOldGenerationAllocationLimit and SetOldGenerationAllocationLimit should
also be private and should go where  DampenOldGenerationAllocationLimit went. We
can also make a "heap growing strategy section"

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1090
src/heap/heap.h:1090: inline bool ShouldBePromoted(Address old_address, int
object_size);
Also a private.

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1102
src/heap/heap.h:1102: inline bool OldGenerationAllocationLimitReached();
This one should also be next to the other growing strategy functions.

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1108
src/heap/heap.h:1108: bool RecentIdleNotificationHappened();
Private. There should be a section for them.

[Michael Starzinger, 2015-08-24 16:55:47]

Nice. I love it. LGTM.

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h
File src/heap/heap-inl.h (left):

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h#oldcode326
src/heap/heap-inl.h:326: void Heap::PrintAlloctionsHash() {
On 2015/08/24 16:36:36, Michael Lippautz wrote:
> Any reason this debug method using prints is inlined?

Nah, can't think of any. Probably just to have is "close" to
Heap::UpdateAllocationsHash above. Moving to the heap.cc files looks fine to me.

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1707
src/heap/heap.h:1707: void GarbageCollectionEpilogue();
Can both go into the "Actual GC" section as well, probably near the top of that
section, as it is common to scavenge and full GC.

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1766
src/heap/heap.h:1766: void Scavenge();
Can go into the "Actual GC" section, right before DoScavenge.

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1778
src/heap/heap.h:1778: void ProcessAllocationSites(WeakObjectRetainer* retainer);
Can both go into the "Actual GC" section after ProcessAllWeakReferences and
ProcessYoungWeakReferences.

[Michael Lippautz, 2015-08-25 06:54:42]

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h
File src/heap/heap-inl.h (left):

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h#oldcode326
src/heap/heap-inl.h:326: void Heap::PrintAlloctionsHash() {
On 2015/08/24 16:55:47, Michael Starzinger wrote:
> On 2015/08/24 16:36:36, Michael Lippautz wrote:
> > Any reason this debug method using prints is inlined?
> 
> Nah, can't think of any. Probably just to have is "close" to
> Heap::UpdateAllocationsHash above. Moving to the heap.cc files looks fine to
me.

Done.

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h#oldcode326
src/heap/heap-inl.h:326: void Heap::PrintAlloctionsHash() {
On 2015/08/24 16:43:53, Hannes Payer wrote:
> On 2015/08/24 16:36:36, Michael Lippautz wrote:
> > Any reason this debug method using prints is inlined?
> 
> Be gone.

Done.

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1090
src/heap/heap.h:1090: inline bool ShouldBePromoted(Address old_address, int
object_size);
On 2015/08/24 16:43:53, Hannes Payer wrote:
> Also a private.

Can't as {ScavengingVisitor} (which is not a friend) is using it.

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1102
src/heap/heap.h:1102: inline bool OldGenerationAllocationLimitReached();
On 2015/08/24 16:43:53, Hannes Payer wrote:
> This one should also be next to the other growing strategy functions.

Done.

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1108
src/heap/heap.h:1108: bool RecentIdleNotificationHappened();
On 2015/08/24 16:43:53, Hannes Payer wrote:
> Private. There should be a section for them.

Done.

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1707
src/heap/heap.h:1707: void GarbageCollectionEpilogue();
On 2015/08/24 16:55:47, Michael Starzinger wrote:
> Can both go into the "Actual GC" section as well, probably near the top of
that
> section, as it is common to scavenge and full GC.

Done.

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1766
src/heap/heap.h:1766: void Scavenge();
On 2015/08/24 16:55:47, Michael Starzinger wrote:
> Can go into the "Actual GC" section, right before DoScavenge.

Done.

https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1778
src/heap/heap.h:1778: void ProcessAllocationSites(WeakObjectRetainer* retainer);
On 2015/08/24 16:55:47, Michael Starzinger wrote:
> Can both go into the "Actual GC" section after ProcessAllWeakReferences and
> ProcessYoungWeakReferences.

Done.

[Hannes Payer (out of office), 2015-08-25 07:35:15]

lgtm

[Michael Lippautz, 2015-08-25 07:47:48]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2015-08-25 07:47:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1313513003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2015-08-25 07:47:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1313513003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1313513003/40001

[commit-bot: I haz the power, 2015-08-25 08:24:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-25 08:24:20]

Patchset 3 (id:??) landed as
https://crrev.com/e4d6f1dec101b6a148420c4e3e9330536de6ae9e
Cr-Commit-Position: refs/heads/master@{#30344}