Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: LayoutTests/http/tests/push_messaging/subscribe-failure-permission-denied-in-document.html

Issue 1313493003: Re-enable a push subscription-without-permission layout test. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/http/tests/push_messaging/subscribe-failure-permission-denied-in-document.html
diff --git a/LayoutTests/http/tests/push_messaging/subscribe-failure-permission-denied-in-document.html b/LayoutTests/http/tests/push_messaging/subscribe-failure-permission-denied-in-document.html
index 61815383db49970a2d33a2846b8ee45992bed75f..1feb6c637e2f65734c45e38497f18a8a0fd37344 100644
--- a/LayoutTests/http/tests/push_messaging/subscribe-failure-permission-denied-in-document.html
+++ b/LayoutTests/http/tests/push_messaging/subscribe-failure-permission-denied-in-document.html
@@ -27,8 +27,7 @@ async_test(function(test) {
.then(function(pushSubscription) {
assert_unreached('Subscription must not succeed after permission is denied.');
}, function(e) {
- // TODO(peter): Re-enable this assert when the appropriate error is being thrown.
- //assert_equals(e.name, 'AbortError');
+ assert_equals(e.name, 'PermissionDeniedError');
assert_regexp_match(e.message, /permission denied/);
return service_worker_unregister_and_done(test, workerScope);
})
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698