Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: components/translate/core/language_detection/BUILD.gn

Issue 1313463002: Revert of Add more components_unittests to GN build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tests4
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/translate/core/common/BUILD.gn ('k') | components/url_matcher/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/translate/core/language_detection/BUILD.gn
diff --git a/components/translate/core/language_detection/BUILD.gn b/components/translate/core/language_detection/BUILD.gn
index a1d15efe0fb982cbe33d0856d98c6740a8aa01c1..57e1d10fb642fb951b19125a5339e7234c8395c9 100644
--- a/components/translate/core/language_detection/BUILD.gn
+++ b/components/translate/core/language_detection/BUILD.gn
@@ -4,7 +4,7 @@
import("//build/config/features.gni")
-source_set("language_detection") {
+static_library("language_detection") {
sources = [
"language_detection_util.cc",
"language_detection_util.h",
@@ -18,20 +18,8 @@
if (cld_version == 1) {
deps += [ "//third_party/cld" ]
- } else if (cld_version == 2) {
- deps += [ "//third_party/cld_2:cld2_platform_impl" ]
- } else {
- assert(false, "Need a CLD version")
+ }
+ if (cld_version == 2) {
+ deps += [ "//third_party/cld_2" ]
}
}
-
-source_set("unit_tests") {
- testonly = true
- sources = [
- "language_detection_util_unittest.cc",
- ]
- deps = [
- ":language_detection",
- "//testing/gtest",
- ]
-}
« no previous file with comments | « components/translate/core/common/BUILD.gn ('k') | components/url_matcher/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698