Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: components/storage_monitor/BUILD.gn

Issue 1313463002: Revert of Add more components_unittests to GN build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tests4
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/search_provider_logos/BUILD.gn ('k') | components/sync_driver/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/storage_monitor/BUILD.gn
diff --git a/components/storage_monitor/BUILD.gn b/components/storage_monitor/BUILD.gn
index bb7034b23fa6646964ceff0266b51a5477f12063..48b34d04380cc64a170779da19209ded505d3106 100644
--- a/components/storage_monitor/BUILD.gn
+++ b/components/storage_monitor/BUILD.gn
@@ -5,7 +5,7 @@
import("//build/config/features.gni")
# GYP version: components/storage_monitor.gypi:storage_monitor
-source_set("storage_monitor") {
+static_library("storage_monitor") {
sources = [
"image_capture_device.h",
"image_capture_device.mm",
@@ -85,7 +85,7 @@
}
# GYP version: components/storage_monitor.gypi:storage_monitor_test_support
-source_set("test_support") {
+static_library("test_support") {
sources = [
"mock_removable_storage_observer.cc",
"mock_removable_storage_observer.h",
@@ -101,44 +101,16 @@
"test_volume_mount_watcher_win.h",
]
- public_deps = [
+ deps = [
+ "//base",
":storage_monitor",
- "//base",
]
if (is_linux) {
- deps = [
+ deps += [
"//device/media_transfer_protocol",
"//device/media_transfer_protocol:mtp_file_entry_proto",
"//device/media_transfer_protocol:mtp_storage_info_proto",
]
}
}
-
-source_set("unit_tests") {
- testonly = true
- sources = [
- "image_capture_device_manager_unittest.mm",
- "media_storage_util_unittest.cc",
- "media_transfer_protocol_device_observer_linux_unittest.cc",
- "storage_info_unittest.cc",
- "storage_monitor_mac_unittest.mm",
- "storage_monitor_unittest.cc",
- "storage_monitor_win_unittest.cc",
- ]
- deps = [
- ":test_support",
- "//testing/gtest",
- ]
-
- if (is_linux && !is_chromeos) {
- sources += [ "storage_monitor_linux_unittest.cc" ]
- }
- if (is_chromeos) {
- sources += [ "storage_monitor_chromeos_unittest.cc" ]
- deps += [
- "//chromeos:test_support",
- "//testing/gmock",
- ]
- }
-}
« no previous file with comments | « components/search_provider_logos/BUILD.gn ('k') | components/sync_driver/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698