Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1422)

Unified Diff: chrome/browser/resources/md_downloads/item.js

Issue 1313453002: Make cr.ui.Focus* play nice with Shadow DOM and MD chrome://downloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_downloads/item.js
diff --git a/chrome/browser/resources/md_downloads/item.js b/chrome/browser/resources/md_downloads/item.js
index 478667b32b052a75c27b611c0838b8dea6afae1a..8cbc084ae9cedf818f87cb0fb7c638c1719df9aa 100644
--- a/chrome/browser/resources/md_downloads/item.js
+++ b/chrome/browser/resources/md_downloads/item.js
@@ -25,6 +25,15 @@ cr.define('downloads', function() {
value: false,
},
+ readyPromise: {
+ type: Object,
+ value: function() {
+ return new Promise(function(resolve, reject) {
+ this.resolveReadyPromise_ = resolve;
+ }.bind(this));
+ },
+ },
+
scrollbarWidth: {
type: Number,
value: 0,
@@ -45,6 +54,11 @@ cr.define('downloads', function() {
isMalware_: Boolean,
},
+ ready: function() {
+ this.content = this.$.content;
+ this.resolveReadyPromise_();
+ },
+
/** @param {!downloads.Data} data */
update: function(data) {
assert(!this.id_ || data.id == this.id_);
@@ -130,7 +144,6 @@ cr.define('downloads', function() {
if (controlledByExtension) {
var link = this.$['controlled-by'].querySelector('a');
link.href = 'chrome://extensions#' + data.by_ext_id;
- link.setAttribute('focus-type', 'controlled-by');
link.textContent = data.by_ext_name;
}

Powered by Google App Engine
This is Rietveld 408576698