Issue 131343013: Test and fix for _CallFunction intrinsic deoptimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131343013: Test and fix for _CallFunction intrinsic deoptimization. (Closed)

Created:
6 years, 10 months ago by Jarin

Modified:
6 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Test and fix for _CallFunction intrinsic deoptimization. I have also cleaned up HOptimizedGraphBuilder::GenerateCallFunction to use IfBuilder. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19151

Patch Set 1 #

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -33 lines)			Patch
	M	src/hydrogen.cc	View		1 chunk	+32 lines, -24 lines	2 comments	Download
	A +	test/mjsunit/regress/call-function-in-effect-context-deopt.js	View		1 chunk	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with a nit. https://codereview.chromium.org/131343013/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/131343013/diff/1/src/hydrogen.cc#newcode10547 src/hydrogen.cc:10547: Add<HInvokeFunction>(function, arg_count); nit: 4 spaces ...

6 years, 10 months ago (2014-02-06 12:19:52 UTC) #2

Jarin

6 years, 10 months ago (2014-02-06 12:42:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19151 (presubmit successful).

Expand Messages | Collapse Messages