Issue 131343003: Revert 243938 "Enable all ESC-Fullscreen tests (Chrome Apps) for..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131343003: Revert 243938 "Enable all ESC-Fullscreen tests (Chrome Apps) for..." (Closed)

Created:
6 years, 11 months ago by Noam Samuel

Modified:
6 years, 11 months ago

Reviewers:
mlamouri (slow - plz ping)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 243938 "Enable all ESC-Fullscreen tests (Chrome Apps) for..." > Enable all ESC-Fullscreen tests (Chrome Apps) for all platforms. > > There were three issues: > 1. a silly bug in the fullscreen change check; > 2. there was no guarantee that the window would be actually focused; > 3. changing the fullscreen state might come with an animation during which key events will not be received. > > Note that 2 and 3 are a problem on MacOS only. > > BUG=None > > Review URL: https://codereview.chromium.org/116023002 TBR=mlamouri@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243955

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -70 lines)			Patch
M	trunk/src/chrome/browser/apps/app_window_interactive_uitest.cc	View	10 chunks	+31 lines, -58 lines	0 comments	Download
M	trunk/src/chrome/test/data/extensions/platform_apps/leave_fullscreen/main.js	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/test/data/extensions/platform_apps/prevent_leave_fullscreen/main.js	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r243955.

Expand Messages | Collapse Messages