chrome/chrome_browser.gypi - Issue 1313383006: Don't compile save_password_infobar_delegate.cc everywhere but Mac and Android

Unified Diff: chrome/chrome_browser.gypi

Issue 1313383006: Don't compile save_password_infobar_delegate.cc everywhere but Mac and Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/chrome_password_manager_client.cc ('K') | « chrome/browser/ui/views/infobars/save_password_infobar.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 5636b33c2bb1628bd04e3a092e9d5cc30f9bc364..38cc0fc3863c3a324e8bb01676e18bdeee280171 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -2048,6 +2048,7 @@

'third_party/mozilla_security_manager/nsUsageArrayHelper.cpp',

'third_party/mozilla_security_manager/nsUsageArrayHelper.h',

+ # Used everywhere but Mac and Android.

Peter Kasting 2015/09/08 08:20:00 I'm not sure this comment is accurate. Do we real

ki.stfu 2015/09/08 09:22:20 Oops. It's a typo. I'll remove this comment at all

ki.stfu 2015/09/08 20:39:54 Done.

'chrome_browser_password_manager_sources': [

'browser/password_manager/chrome_password_manager_client.cc',

'browser/password_manager/chrome_password_manager_client.h',

@@ -2062,11 +2063,14 @@

'browser/password_manager/password_store_win.h',

'browser/password_manager/password_store_x.cc',

'browser/password_manager/password_store_x.h',

- 'browser/password_manager/save_password_infobar_delegate.cc',

- 'browser/password_manager/save_password_infobar_delegate.h',

'browser/password_manager/simple_password_store_mac.cc',

'browser/password_manager/simple_password_store_mac.h',

+ # Used on Mac and Android platforms.

+ 'chrome_browser_password_manager_mac_android_sources': [

+ 'browser/password_manager/save_password_infobar_delegate.cc',

+ 'browser/password_manager/save_password_infobar_delegate.h',

+ ],

'chrome_browser_permissions_sources': [

'browser/permissions/permission_bubble_request_impl.cc',

'browser/permissions/permission_bubble_request_impl.h',

@@ -3387,6 +3391,11 @@

'sources': [ '<@(chrome_browser_mac_sources)' ]

}],

+ ['OS=="mac" or OS=="android"', {

+ 'sources': [

+ '<@(chrome_browser_password_manager_mac_android_sources)',

+ ],

+ }],

['chromeos==1', {

'sources!': [

'browser/metrics/signin_status_metrics_provider.cc',