chrome/browser/ui/views/infobars/save_password_infobar.cc - Issue 1313383006: Don't compile save_password_infobar_delegate.cc everywhere but Mac and Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/infobars/save_password_infobar.cc

Issue 1313383006: Don't compile save_password_infobar_delegate.cc everywhere but Mac and Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make a bit refactoring Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.

4

5 #include "chrome/browser/password_manager/save_password_infobar_delegate.h"

6 #include "chrome/browser/ui/views/infobars/confirm_infobar.h"

7
ki.stfu 2015/09/15 11:06:53 Forgot to add tapted@'s comment here: // TODO(tap Forgot to add tapted@'s comment here: // TODO(tapted): Delete this file when Mac uses the password bubble by default. tapted 2015/09/15 23:55:32 (note I don't see a change to save_password_infoba Show quoted text On 2015/09/15 11:06:53, ki.stfu wrote: > Forgot to add tapted@'s comment here: > > // TODO(tapted): Delete this file when Mac uses the password bubble by default. (note I don't see a change to save_password_infobar.cc in the latest patchset, but I'm indifferent about whether this gets added -- there's already a TODO in the gypi -- i.e. to remove that entire gyp variable at some point, and the file should get reaped at the same time) ki.stfu 2015/09/16 09:21:03 Agreed. But TODO in .c file is seen to everyone wh Show quoted text On 2015/09/15 23:55:32, tapted wrote: > On 2015/09/15 11:06:53, ki.stfu wrote: > > Forgot to add tapted@'s comment here: > > > > // TODO(tapted): Delete this file when Mac uses the password bubble by > default. > > (note I don't see a change to save_password_infobar.cc in the latest patchset, > but I'm indifferent about whether this gets added -- there's already a TODO in > the gypi -- i.e. to remove that entire gyp variable at some point, and the file > should get reaped at the same time) Agreed. But TODO in .c file is seen to everyone who interested in this file, in contrast to the TODO in gypi.
8 scoped_ptr<infobars::InfoBar> CreateSavePasswordInfoBar(

9 scoped_ptr<SavePasswordInfoBarDelegate> delegate) {

10 return make_scoped_ptr(new ConfirmInfoBar(delegate.Pass()));

11 }

OLD	NEW

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | chrome/chrome_browser.gypi » ('j') | chrome/chrome_browser_ui.gypi » ('J')