chrome/browser/ui/views/infobars/save_password_infobar.cc - Issue 1313383006: Don't compile save_password_infobar_delegate.cc everywhere but Mac and Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/infobars/save_password_infobar.cc

Issue 1313383006: Don't compile save_password_infobar_delegate.cc everywhere but Mac and Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Exclude kEnableSavePasswordBubble/kDisableSavePasswordBubble definitions on Aura platforms Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/password_manager/chrome_password_manager_client.cc ('K') | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | chrome/chrome_browser.gypi » ('j') | chrome/common/chrome_switches.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.

4

5 #include "chrome/browser/password_manager/save_password_infobar_delegate.h"

6 #include "chrome/browser/ui/views/infobars/confirm_infobar.h"

7

8 scoped_ptr<infobars::InfoBar> CreateSavePasswordInfoBar(
vabr (Chromium) 2015/09/10 07:21:47 Isn't this used by Android (and Mac with views)? Isn't this used by Android (and Mac with views)? ki.stfu 2015/09/10 18:21:00 I think no. Android has its own version of CreateS Show quoted text On 2015/09/10 07:21:47, vabr (Chromium) wrote: > Isn't this used by Android (and Mac with views)? I think no. Android has its own version of CreateSavePasswordInfoBar, which is implemented here: chrome/browser/ui/android/infobars/save_password_infobar.cc. vabr (Chromium) 2015/09/10 18:48:12 Fair enough. The Android trybot also compiled patc Show quoted text On 2015/09/10 18:21:00, ki.stfu wrote: > On 2015/09/10 07:21:47, vabr (Chromium) wrote: > > Isn't this used by Android (and Mac with views)? > > I think no. Android has its own version of CreateSavePasswordInfoBar, which is > implemented here: chrome/browser/ui/android/infobars/save_password_infobar.cc. Fair enough. The Android trybot also compiled patch set 4 without problems.
9 scoped_ptr<SavePasswordInfoBarDelegate> delegate) {

10 return make_scoped_ptr(new ConfirmInfoBar(delegate.Pass()));

11 }

OLD	NEW