Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1313383005:
Clear SMI and non-evacuation candidate entries when filtering the slots buffer. (Closed)
|
Created:
5 years, 3 months ago by Hannes Payer (out of office) Modified:
5 years, 3 months ago Reviewers:
Igor Sheludko CC:
v8-dev Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionClear SMI and non-evacuation candidate entries when filtering the slots buffer.
BUG=
Committed: https://crrev.com/d4e372b41b91665ea8398e510dd30072c1a88a4f
Cr-Commit-Position: refs/heads/master@{#30415}
Patch Set 1 #
Total comments: 4
Patch Set 2 : #Patch Set 3 : #
Total comments: 1
Patch Set 4 : #Messages
Total messages: 24 (10 generated)
hpayer@chromium.org changed reviewers: + ishell@chromium.org
https://codereview.chromium.org/1313383005/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1313383005/diff/1/src/heap/mark-compact.cc#ne... src/heap/mark-compact.cc:4510: (object->IsHeapObject() && heap->InNewSpace(object)) || You can remove object->IsHeapObject() part from here. https://codereview.chromium.org/1313383005/diff/1/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/1313383005/diff/1/test/cctest/test-heap.cc#ne... test/cctest/test-heap.cc:6497: // we point to an evacuation candidate object which should not be filtered I'm afraid this last part is missing.
https://codereview.chromium.org/1313383005/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1313383005/diff/1/src/heap/mark-compact.cc#ne... src/heap/mark-compact.cc:4510: (object->IsHeapObject() && heap->InNewSpace(object)) || On 2015/08/27 07:04:31, Igor Sheludko wrote: > You can remove object->IsHeapObject() part from here. Done. https://codereview.chromium.org/1313383005/diff/1/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/1313383005/diff/1/test/cctest/test-heap.cc#ne... test/cctest/test-heap.cc:6497: // we point to an evacuation candidate object which should not be filtered On 2015/08/27 07:04:31, Igor Sheludko wrote: > I'm afraid this last part is missing. Oh, yes. Done.
lgtm
The CQ bit was checked by hpayer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313383005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313383005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
This code is tricky! Small fix. https://codereview.chromium.org/1313383005/diff/40001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1313383005/diff/40001/src/heap/mark-compact.c... src/heap/mark-compact.cc:4533: !Page::FromAddress(reinterpret_cast<Address>(object)) Order is important here. Checking for evacuation candidate before would crash if the slot contained a double.
The CQ bit was checked by hpayer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org Link to the patchset: https://codereview.chromium.org/1313383005/#ps40001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313383005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313383005/40001
The CQ bit was unchecked by hpayer@chromium.org
The CQ bit was checked by hpayer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313383005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313383005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
The CQ bit was checked by hpayer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org Link to the patchset: https://codereview.chromium.org/1313383005/#ps60001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313383005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313383005/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/d4e372b41b91665ea8398e510dd30072c1a88a4f Cr-Commit-Position: refs/heads/master@{#30415} |
