Issue 1313383004: Support the latest internal test API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1313383004: Support the latest internal test API. (Closed)

Created:
5 years, 3 months ago by nweiz

Modified:
5 years, 3 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/metatest@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Support the latest internal test API. Closes dart-lang/scheduled_test#21 R=kevmoo@google.com Committed: https://github.com/dart-lang/metatest/commit/fab71ac29fc1a78933e523120a42a8e323f534d1

Patch Set 2 : Code review changes #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
M	.gitignore	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/metatest.dart	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
M	pubspec.yaml	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

LGTM w/ one nit Also: ignore .packages while you're at it? https://codereview.chromium.org/1313383004/diff/1/lib/metatest.dart File lib/metatest.dart (right): ...

5 years, 3 months ago (2015-08-26 21:25:39 UTC) #2

nweiz

https://codereview.chromium.org/1313383004/diff/1/lib/metatest.dart File lib/metatest.dart (right): https://codereview.chromium.org/1313383004/diff/1/lib/metatest.dart#newcode18 lib/metatest.dart:18: import 'package:test/src/backend/suite.dart'; On 2015/08/26 21:25:39, kevmoo wrote: > now ...

5 years, 3 months ago (2015-08-26 21:28:00 UTC) #4

nweiz

5 years, 3 months ago (2015-08-26 21:28:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
fab71ac29fc1a78933e523120a42a8e323f534d1 (presubmit successful).

Expand Messages | Collapse Messages

Issue 1313383004: Support the latest internal test API. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review changes #

Messages