Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(21)

Issue 1313383004: Support the latest internal test API. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/metatest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support the latest internal test API. Closes dart-lang/scheduled_test#21 R=kevmoo@google.com Committed: https://github.com/dart-lang/metatest/commit/fab71ac29fc1a78933e523120a42a8e323f534d1

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M .gitignore View 1 1 chunk +1 line, -0 lines 0 comments Download
M lib/metatest.dart View 1 2 chunks +5 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
4 years, 10 months ago (2015-08-26 21:22:04 UTC) #1
kevmoo
LGTM w/ one nit Also: ignore .packages while you're at it? https://codereview.chromium.org/1313383004/diff/1/lib/metatest.dart File lib/metatest.dart (right): ...
4 years, 10 months ago (2015-08-26 21:25:39 UTC) #2
nweiz
Code review changes
4 years, 10 months ago (2015-08-26 21:27:54 UTC) #3
nweiz
https://codereview.chromium.org/1313383004/diff/1/lib/metatest.dart File lib/metatest.dart (right): https://codereview.chromium.org/1313383004/diff/1/lib/metatest.dart#newcode18 lib/metatest.dart:18: import 'package:test/src/backend/suite.dart'; On 2015/08/26 21:25:39, kevmoo wrote: > now ...
4 years, 10 months ago (2015-08-26 21:28:00 UTC) #4
nweiz
4 years, 10 months ago (2015-08-26 21:28:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fab71ac29fc1a78933e523120a42a8e323f534d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698