content/browser/notifications/notification_database_data.proto - Issue 1313363006: Plumb requireInteraction to PlatformNotificationData & database

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/notification_database_data.proto

Issue 1313363006: Plumb requireInteraction to PlatformNotificationData & database (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@constructor

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/notifications/notification_database_data_conversions.cc » ('j') | content/public/common/platform_notification_data.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/notification_database_data.proto

diff --git a/content/browser/notifications/notification_database_data.proto b/content/browser/notifications/notification_database_data.proto

index a634456860f6eb91938279286256fbff2d64e607..3047d2b4356e28c5b79410ad156eb755fd97687b 100644

--- a/content/browser/notifications/notification_database_data.proto

+++ b/content/browser/notifications/notification_database_data.proto

@@ -29,7 +29,7 @@ message NotificationDatabaseDataProto {

// Actual data payload of the notification. This message is the protocol

// buffer meant to serialize the content::PlatformNotificationData structure.

- // Next tag: 11

+ // Next tag: 12

message NotificationData {

enum Direction {

LEFT_TO_RIGHT = 0;

@@ -45,6 +45,7 @@ message NotificationDatabaseDataProto {

optional string icon = 6;

repeated int32 vibration_pattern = 9 [packed=true];

optional bool silent = 7;

+ optional bool require_interaction = 11;

optional bytes data = 8;

repeated NotificationAction actions = 10;

}