runtime/vm/object.h - Issue 1313363005: Use zone allocated C-strings instead of String heap objects to construct signature symbols

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.h

Issue 1313363005: Use zone allocated C-strings instead of String heap objects to construct signature symbols (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Address comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.h

diff --git a/runtime/vm/object.h b/runtime/vm/object.h

index 236814749f8e1fba1a14e091000096b092f4244f..e80096bf7c672561fba3b0899872696377348a1e 100644

--- a/runtime/vm/object.h

+++ b/runtime/vm/object.h

@@ -2700,7 +2700,7 @@ FOR_EACH_FUNCTION_KIND_BIT(DEFINE_BIT)

void BuildSignatureParameters(bool instantiate,

NameVisibility name_visibility,

const TypeArguments& instantiator,

- const GrowableObjectArray& pieces) const;

+ GrowableArray<const String*>* pieces) const;

RawString* BuildSignature(bool instantiate,

NameVisibility name_visibility,

const TypeArguments& instantiator) const;

« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »