runtime/vm/symbols.h - Issue 1313363005: Use zone allocated C-strings instead of String heap objects to construct signature symbols

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/symbols.h

Issue 1313363005: Use zone allocated C-strings instead of String heap objects to construct signature symbols (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Simplify Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/symbols.h

diff --git a/runtime/vm/symbols.h b/runtime/vm/symbols.h

index 97c6ce10d6aff9f9282d16626a9d6a97c4838fd3..91619cf207606a0f9358c86d8c642b96d1e569e4 100644

--- a/runtime/vm/symbols.h

+++ b/runtime/vm/symbols.h

@@ -594,6 +594,8 @@ class Symbols : public AllStatic {

static RawString* FromConcat(const String& str1, const String& str2);

+ static RawString* FromConcatAll(const GrowableArray<const String*>& strs);

// Returns char* of predefined symbol.

static const char* Name(SymbolId symbol);

« runtime/vm/object.cc ('K') | « runtime/vm/object.cc ('k') | runtime/vm/symbols.cc » ('j') | runtime/vm/symbols.cc » ('J')