Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1313363004: [Password Manager] Extract some methods of SavePasswordInfobarDelegate to separate class. (Closed)

Created:
5 years, 3 months ago by melandory
Modified:
5 years, 2 months ago
Reviewers:
dvadym
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password Manager] Extract some methods of SavePasswordInfobarDelegate to separate class. Some methods of the SavePasswordInfobarDelegate can be reused in other password manager related delegates in the future, e.g. delegate for the update password infobar. So this patch introduces the base class for the password manager infobar's delegates. BUG=359315, 532876 Committed: https://crrev.com/d2f1f4bed6f43f5bcf16f242c83b9b6048fdf9dc Cr-Commit-Position: refs/heads/master@{#351069}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -54 lines) Patch
A chrome/browser/password_manager/password_manager_infobar_delegate.h View 1 2 1 chunk +45 lines, -0 lines 0 comments Download
A chrome/browser/password_manager/password_manager_infobar_delegate.cc View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/save_password_infobar_delegate.h View 1 2 4 chunks +2 lines, -16 lines 0 comments Download
M chrome/browser/password_manager/save_password_infobar_delegate.cc View 1 2 4 chunks +6 lines, -38 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
melandory
Hey Vadym, PTAL. Thanks!
5 years, 2 months ago (2015-09-28 11:39:05 UTC) #6
dvadym
On 2015/09/28 11:39:05, melandory wrote: > Hey Vadym, > > PTAL. Thanks! LGTM
5 years, 2 months ago (2015-09-28 14:02:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313363004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313363004/120001
5 years, 2 months ago (2015-09-28 14:12:37 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:120001)
5 years, 2 months ago (2015-09-28 14:59:26 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 15:00:03 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d2f1f4bed6f43f5bcf16f242c83b9b6048fdf9dc
Cr-Commit-Position: refs/heads/master@{#351069}

Powered by Google App Engine
This is Rietveld 408576698