Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: content/common/ssl_status_serialization.cc

Issue 1313363003: Expose OpenSSL's key_exchange_info in the content API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Proper #ifdef fix Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/common/ssl_status_serialization.h" 5 #include "content/common/ssl_status_serialization.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/pickle.h" 8 #include "base/pickle.h"
9 9
10 namespace { 10 namespace {
(...skipping 15 matching lines...) Expand all
26 } // namespace 26 } // namespace
27 27
28 namespace content { 28 namespace content {
29 29
30 std::string SerializeSecurityInfo(const SSLStatus& ssl_status) { 30 std::string SerializeSecurityInfo(const SSLStatus& ssl_status) {
31 base::Pickle pickle; 31 base::Pickle pickle;
32 pickle.WriteInt(ssl_status.security_style); 32 pickle.WriteInt(ssl_status.security_style);
33 pickle.WriteInt(ssl_status.cert_id); 33 pickle.WriteInt(ssl_status.cert_id);
34 pickle.WriteUInt32(ssl_status.cert_status); 34 pickle.WriteUInt32(ssl_status.cert_status);
35 pickle.WriteInt(ssl_status.security_bits); 35 pickle.WriteInt(ssl_status.security_bits);
36 pickle.WriteInt(ssl_status.key_exchange_info);
36 pickle.WriteInt(ssl_status.connection_status); 37 pickle.WriteInt(ssl_status.connection_status);
37 pickle.WriteInt(ssl_status.signed_certificate_timestamp_ids.size()); 38 pickle.WriteInt(ssl_status.signed_certificate_timestamp_ids.size());
38 for (SignedCertificateTimestampIDStatusList::const_iterator iter = 39 for (SignedCertificateTimestampIDStatusList::const_iterator iter =
39 ssl_status.signed_certificate_timestamp_ids.begin(); 40 ssl_status.signed_certificate_timestamp_ids.begin();
40 iter != ssl_status.signed_certificate_timestamp_ids.end(); ++iter) { 41 iter != ssl_status.signed_certificate_timestamp_ids.end(); ++iter) {
41 pickle.WriteInt(iter->id); 42 pickle.WriteInt(iter->id);
42 pickle.WriteUInt16(iter->status); 43 pickle.WriteUInt16(iter->status);
43 } 44 }
44 return std::string(static_cast<const char*>(pickle.data()), pickle.size()); 45 return std::string(static_cast<const char*>(pickle.data()), pickle.size());
45 } 46 }
46 47
47 bool DeserializeSecurityInfo(const std::string& state, SSLStatus* ssl_status) { 48 bool DeserializeSecurityInfo(const std::string& state, SSLStatus* ssl_status) {
48 *ssl_status = SSLStatus(); 49 *ssl_status = SSLStatus();
49 50
50 if (state.empty()) { 51 if (state.empty()) {
51 // No SSL used. 52 // No SSL used.
52 return true; 53 return true;
53 } 54 }
54 55
55 base::Pickle pickle(state.data(), static_cast<int>(state.size())); 56 base::Pickle pickle(state.data(), static_cast<int>(state.size()));
56 base::PickleIterator iter(pickle); 57 base::PickleIterator iter(pickle);
57 int security_style; 58 int security_style;
58 int num_scts_to_read; 59 int num_scts_to_read;
59 if (!iter.ReadInt(&security_style) || !iter.ReadInt(&ssl_status->cert_id) || 60 if (!iter.ReadInt(&security_style) || !iter.ReadInt(&ssl_status->cert_id) ||
60 !iter.ReadUInt32(&ssl_status->cert_status) || 61 !iter.ReadUInt32(&ssl_status->cert_status) ||
61 !iter.ReadInt(&ssl_status->security_bits) || 62 !iter.ReadInt(&ssl_status->security_bits) ||
63 !iter.ReadInt(&ssl_status->key_exchange_info) ||
62 !iter.ReadInt(&ssl_status->connection_status) || 64 !iter.ReadInt(&ssl_status->connection_status) ||
63 !iter.ReadInt(&num_scts_to_read)) { 65 !iter.ReadInt(&num_scts_to_read)) {
64 *ssl_status = SSLStatus(); 66 *ssl_status = SSLStatus();
65 return false; 67 return false;
66 } 68 }
67 69
68 if (!CheckSecurityStyle(security_style)) { 70 if (!CheckSecurityStyle(security_style)) {
69 *ssl_status = SSLStatus(); 71 *ssl_status = SSLStatus();
70 return false; 72 return false;
71 } 73 }
72 74
73 ssl_status->security_style = static_cast<SecurityStyle>(security_style); 75 ssl_status->security_style = static_cast<SecurityStyle>(security_style);
74 76
75 // Sanity check |security_bits|: the only allowed negative value is -1. 77 // Sanity check |security_bits|: the only allowed negative value is -1.
76 if (ssl_status->security_bits < -1) { 78 if (ssl_status->security_bits < -1) {
77 *ssl_status = SSLStatus(); 79 *ssl_status = SSLStatus();
78 return false; 80 return false;
79 } 81 }
80 82
83 // Sanity check |key_exchange_info|: 0 or greater.
84 if (ssl_status->key_exchange_info < 0) {
85 *ssl_status = SSLStatus();
86 return false;
87 }
88
81 for (; num_scts_to_read > 0; --num_scts_to_read) { 89 for (; num_scts_to_read > 0; --num_scts_to_read) {
82 int id; 90 int id;
83 uint16 status; 91 uint16 status;
84 if (!iter.ReadInt(&id) || !iter.ReadUInt16(&status)) { 92 if (!iter.ReadInt(&id) || !iter.ReadUInt16(&status)) {
85 *ssl_status = SSLStatus(); 93 *ssl_status = SSLStatus();
86 return false; 94 return false;
87 } 95 }
88 96
89 ssl_status->signed_certificate_timestamp_ids.push_back( 97 ssl_status->signed_certificate_timestamp_ids.push_back(
90 SignedCertificateTimestampIDAndStatus( 98 SignedCertificateTimestampIDAndStatus(
91 id, static_cast<net::ct::SCTVerifyStatus>(status))); 99 id, static_cast<net::ct::SCTVerifyStatus>(status)));
92 } 100 }
93 101
94 return true; 102 return true;
95 } 103 }
96 104
97 } // namespace content 105 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/loader/resource_loader.cc ('k') | content/common/ssl_status_serialization_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698