Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: components/pdf_viewer/pdf_viewer.cc

Issue 1313353010: Overhaul Mandoline event transport code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments2 Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/pdf_viewer/pdf_viewer.cc
diff --git a/components/pdf_viewer/pdf_viewer.cc b/components/pdf_viewer/pdf_viewer.cc
index f4d8cab5eced7e02d68e7882e806d6a76eecb334..98e8e1f7ec2c2786cac7f2b5a32f7399b4656ed0 100644
--- a/components/pdf_viewer/pdf_viewer.cc
+++ b/components/pdf_viewer/pdf_viewer.cc
@@ -382,17 +382,20 @@ class PDFView : public mojo::ApplicationDelegate,
return;
}
+ // TODO(rjkroege): Make panning and scrolling more performant and
+ // responsive to gesture events.
if ((event->key_data &&
event->key_data->windows_key_code == mojo::KEYBOARD_CODE_DOWN) ||
- (event->pointer_data && event->pointer_data->vertical_wheel < 0)) {
+ (event->wheel_data && event->wheel_data &&
+ event->wheel_data->delta_y < 0)) {
if (current_page_ < (page_count_ - 1)) {
current_page_++;
DrawBitmap(embedder_for_roots_[view]);
}
} else if ((event->key_data &&
event->key_data->windows_key_code == mojo::KEYBOARD_CODE_UP) ||
- (event->pointer_data &&
- event->pointer_data->vertical_wheel > 0)) {
+ (event->pointer_data && event->wheel_data &&
+ event->wheel_data->delta_y > 0)) {
if (current_page_ > 0) {
current_page_--;
DrawBitmap(embedder_for_roots_[view]);

Powered by Google App Engine
This is Rietveld 408576698