Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(160)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: mojo/converters/input_events/tests/DEPS
Issue
1313353010
:
Overhaul Mandoline event transport code (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments2
Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
components/html_viewer/blink_input_events_type_converters.cc
components/html_viewer/html_frame.cc
components/html_viewer/touch_handler.cc
components/pdf_viewer/pdf_viewer.cc
components/view_manager/display_manager.cc
components/view_manager/event_dispatcher.cc
components/view_manager/gesture_manager.cc
components/view_manager/gesture_manager_unittest.cc
components/view_manager/view_tree_unittest.cc
mojo/BUILD.gn
mojo/converters/input_events/input_events_type_converters.cc
mojo/converters/input_events/tests/BUILD.gn
mojo/converters/input_events/tests/DEPS
mojo/converters/input_events/tests/input_events_unittest.cc
ui/mojo/events/input_event_constants.mojom
ui/mojo/events/input_events.mojom
View unified diff
|
Download patch
« no previous file with comments
|
« mojo/converters/input_events/tests/BUILD.gn
('k') |
mojo/converters/input_events/tests/input_events_unittest.cc »
('j') |
mojo/converters/input_events/tests/input_events_unittest.cc »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 include_rules = [
1 include_rules = [
2
"+
content/public/common
",
2
"+
components/html_viewer
",
sky
2015/09/14 19:27:25
mojo should not depend upon components/html_viewer
mojo should not depend upon components/html_viewer. Maybe move the test there?
rjkroege
2015/09/14 21:07:38
Done.
Show quoted text
On 2015/09/14 19:27:25, sky wrote: > mojo should not depend upon components/html_viewer. Maybe move the test there?
Done.
3 "+third_party/WebKit/public/web",
3 "+third_party/WebKit/public/web",
4 ]
4 ]
OLD
NEW
« no previous file with comments
|
« mojo/converters/input_events/tests/BUILD.gn
('k') |
mojo/converters/input_events/tests/input_events_unittest.cc »
('j') |
mojo/converters/input_events/tests/input_events_unittest.cc »
('J')
Issue 1313353010: Overhaul Mandoline event transport code (Closed)
Created 5 years, 3 months ago by rjkroege
Modified 5 years, 3 months ago
Reviewers: sadrul, sky, jam
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 45
This is Rietveld
408576698