mojo/converters/input_events/tests/DEPS - Issue 1313353010: Overhaul Mandoline event transport code

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/converters/input_events/tests/DEPS

Issue 1313353010: Overhaul Mandoline event transport code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+content/public/common",	2 "+components/html_viewer",
	sadrul 2015/09/09 04:19:04 :( Should the blink converters move into //mojo/c :( Should the blink converters move into //mojo/converters/input_events/ instead (or maybe //mojo/converters/input_events/blink/)? Maybe follow-up patch? rjkroege 2015/09/09 19:45:38 So... I wanted to test the full event life-cycle f Show quoted text On 2015/09/09 04:19:04, sadrul wrote: > :( > > Should the blink converters move into //mojo/converters/input_events/ instead > (or maybe //mojo/converters/input_events/blink/)? Maybe follow-up patch? So... I wanted to test the full event life-cycle from ui::Event to WebEvent. And that meant this. Which is definitely unfortunate from a layering viewpoint. I'm happy to take a TODO to move the blink converters elsewhere. mojo/converters/input_events/blink seem reasonable to me.
3 "+third_party/WebKit/public/web",	3 "+third_party/WebKit/public/web",

4 ]	4 ]

OLD	NEW