Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 1313353006: [test] Return target name on failures. (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Return target name on failures. This information can be used on the buildbot side to only rebuild the failing target for bisection. BUG=chromium:511215 LOG=n NOTRY=true Committed: https://crrev.com/85d1464c4245183402aa098c043f4bc4fd83df02 Cr-Commit-Position: refs/heads/master@{#30617}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/testrunner/local/progress.py View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/1313353006/diff/1/tools/testrunner/local/progress.py File tools/testrunner/local/progress.py (right): https://codereview.chromium.org/1313353006/diff/1/tools/testrunner/local/progress.py#newcode378 tools/testrunner/local/progress.py:378: "target_name": test.suite.shell(), shell name == target name is ...
5 years, 3 months ago (2015-09-07 07:39:10 UTC) #2
Jakob Kummerow
lgtm
5 years, 3 months ago (2015-09-07 08:30:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313353006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313353006/1
5 years, 3 months ago (2015-09-07 10:10:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-07 10:11:35 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 10:11:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85d1464c4245183402aa098c043f4bc4fd83df02
Cr-Commit-Position: refs/heads/master@{#30617}

Powered by Google App Engine
This is Rietveld 408576698