Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Side by Side Diff: src/heap/store-buffer-inl.h

Issue 1313313002: Synchronize on concurrent store buffer entries. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/store-buffer.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_STORE_BUFFER_INL_H_ 5 #ifndef V8_STORE_BUFFER_INL_H_
6 #define V8_STORE_BUFFER_INL_H_ 6 #define V8_STORE_BUFFER_INL_H_
7 7
8 #include "src/heap/heap.h" 8 #include "src/heap/heap.h"
9 #include "src/heap/spaces-inl.h" 9 #include "src/heap/spaces-inl.h"
10 #include "src/heap/store-buffer.h" 10 #include "src/heap/store-buffer.h"
11 11
12 namespace v8 { 12 namespace v8 {
13 namespace internal { 13 namespace internal {
14 14
15 void StoreBuffer::Mark(Address addr) { 15 void StoreBuffer::Mark(Address addr) {
16 DCHECK(!heap_->code_space()->Contains(addr)); 16 DCHECK(!heap_->code_space()->Contains(addr));
17 Address* top = reinterpret_cast<Address*>(heap_->store_buffer_top()); 17 Address* top = reinterpret_cast<Address*>(heap_->store_buffer_top());
18 *top++ = addr; 18 *top++ = addr;
19 heap_->set_store_buffer_top(reinterpret_cast<Smi*>(top)); 19 heap_->set_store_buffer_top(reinterpret_cast<Smi*>(top));
20 if ((reinterpret_cast<uintptr_t>(top) & kStoreBufferOverflowBit) != 0) { 20 if ((reinterpret_cast<uintptr_t>(top) & kStoreBufferOverflowBit) != 0) {
21 DCHECK(top == limit_); 21 DCHECK(top == limit_);
22 Compact(); 22 Compact();
23 } else { 23 } else {
24 DCHECK(top < limit_); 24 DCHECK(top < limit_);
25 } 25 }
26 } 26 }
27 27
28 28
29 inline void StoreBuffer::MarkSynchronized(Address addr) {
30 base::LockGuard<base::Mutex> lock_guard(&mutex_);
31 Mark(addr);
32 }
33
34
29 void StoreBuffer::EnterDirectlyIntoStoreBuffer(Address addr) { 35 void StoreBuffer::EnterDirectlyIntoStoreBuffer(Address addr) {
30 if (store_buffer_rebuilding_enabled_) { 36 if (store_buffer_rebuilding_enabled_) {
31 SLOW_DCHECK(!heap_->code_space()->Contains(addr) && 37 SLOW_DCHECK(!heap_->code_space()->Contains(addr) &&
32 !heap_->new_space()->Contains(addr)); 38 !heap_->new_space()->Contains(addr));
33 Address* top = old_top_; 39 Address* top = old_top_;
34 *top++ = addr; 40 *top++ = addr;
35 old_top_ = top; 41 old_top_ = top;
36 old_buffer_is_sorted_ = false; 42 old_buffer_is_sorted_ = false;
37 old_buffer_is_filtered_ = false; 43 old_buffer_is_filtered_ = false;
38 if (top >= old_limit_) { 44 if (top >= old_limit_) {
39 DCHECK(callback_ != NULL); 45 DCHECK(callback_ != NULL);
40 (*callback_)(heap_, MemoryChunk::FromAnyPointerAddress(heap_, addr), 46 (*callback_)(heap_, MemoryChunk::FromAnyPointerAddress(heap_, addr),
41 kStoreBufferFullEvent); 47 kStoreBufferFullEvent);
42 } 48 }
43 } 49 }
44 } 50 }
45 } 51 }
46 } // namespace v8::internal 52 } // namespace v8::internal
47 53
48 #endif // V8_STORE_BUFFER_INL_H_ 54 #endif // V8_STORE_BUFFER_INL_H_
OLDNEW
« no previous file with comments | « src/heap/store-buffer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698