src/objects.cc - Issue 1313303002: Do not inline array resize operations for outdated prototype maps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 1313303002: Do not inline array resize operations for outdated prototype maps. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 552d4f5516e3feaeb6f2ff9b6e838e5e8c465c34..f0d939411ce03f8d29b789579492afb97f9ab39e 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -1776,6 +1776,8 @@ void JSObject::MigrateToMap(Handle<JSObject> object, Handle<Map> new_map,

if (!new_map->is_dictionary_map()) {

MigrateFastToFast(object, new_map);

if (old_map->is_prototype_map()) {

+ DCHECK(!old_map->is_stable());

+ DCHECK(new_map->is_stable());

// Clear out the old descriptor array to avoid problems to sharing

// the descriptor array without using an explicit.

old_map->InitializeDescriptors(

« no previous file with comments | « src/hydrogen.cc ('k') | test/mjsunit/regress/regress-crbug-523213.js » ('j') | no next file with comments »