Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1313303002: Do not inline array resize operations for outdated prototype maps. (Closed)

Created:
5 years, 3 months ago by Igor Sheludko
Modified:
5 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not inline array resize operations for outdated prototype maps. BUG=chromium:523213 LOG=N Committed: https://crrev.com/590b3bed5cde682b9830b4b78c99fb4961734402 Cr-Commit-Position: refs/heads/master@{#30374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M src/hydrogen.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-523213.js View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL
5 years, 3 months ago (2015-08-26 09:17:03 UTC) #2
mvstanton
Okay, looks like that works! LGTM.
5 years, 3 months ago (2015-08-26 09:20:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313303002/1
5 years, 3 months ago (2015-08-26 09:26:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-26 09:37:51 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 09:38:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/590b3bed5cde682b9830b4b78c99fb4961734402
Cr-Commit-Position: refs/heads/master@{#30374}

Powered by Google App Engine
This is Rietveld 408576698