Re-introduce printers for Node, Position, PositionAnchorType in GTest

Re-introduce printers for Node, Position, PositionAnchorType in GTest

This patch is inspired by http://crrev.com/1257203002, which makes printer for
|WTFString| in GTest.

This patch re-introduces printers for Node, Position and PositionAnchorType in
GTest rather than printing address of pointer by fixing ODR violation for
improving test authoring experience.

In http://crrev.com/1095913003, we introduced |Node| and |Position| printers for
GTest in "CoreTestHelpers.h". However, due by ODR violation, these printers
aren't used in GTest, since some test files uses |Node| as parameters for
GTest macros without including "CoreTestHelpers.h".

Note: ODR stands for One Definition Rule.

See details explanation in http://crrev.com/1257203002.

BUG=514330
TEST=webkit_unit_tests --gtest_fitler=EditingUtilitiesTest.*,VisibleUnitsTest.*

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201207

[yosin_UTC9, 2015-08-26 04:45:46]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2015-08-26 05:02:42]

PTAL

[tkent, 2015-08-26 05:08:37]

lgtm

https://codereview.chromium.org/1313283002/diff/1/Source/core/dom/Node.h
File Source/core/dom/Node.h (right):

https://codereview.chromium.org/1313283002/diff/1/Source/core/dom/Node.h#newc...
Source/core/dom/Node.h:900: std::ostream& operator<<(std::ostream&, const
Node&);
Please add a comment that these functions are for testing, and implementations
are in CoreTestPrinters.cpp.

https://codereview.chromium.org/1313283002/diff/1/Source/core/editing/Position.h
File Source/core/editing/Position.h (right):

https://codereview.chromium.org/1313283002/diff/1/Source/core/editing/Positio...
Source/core/editing/Position.h:393: std::ostream& operator<<(std::ostream&,
PositionAnchorType);
Ditto.

[yosin_UTC9, 2015-08-26 05:36:52]

Thanks for reviewing!

https://codereview.chromium.org/1313283002/diff/1/Source/core/dom/Node.h
File Source/core/dom/Node.h (right):

https://codereview.chromium.org/1313283002/diff/1/Source/core/dom/Node.h#newc...
Source/core/dom/Node.h:900: std::ostream& operator<<(std::ostream&, const
Node&);
On 2015/08/26 05:08:37, tkent wrote:
> Please add a comment that these functions are for testing, and implementations
> are in CoreTestPrinters.cpp.

Done.

https://codereview.chromium.org/1313283002/diff/1/Source/core/editing/Position.h
File Source/core/editing/Position.h (right):

https://codereview.chromium.org/1313283002/diff/1/Source/core/editing/Positio...
Source/core/editing/Position.h:393: std::ostream& operator<<(std::ostream&,
PositionAnchorType);
On 2015/08/26 05:08:37, tkent wrote:
> Ditto.

Done.

[yosin_UTC9, 2015-08-26 05:36:56]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2015-08-26 05:36:57]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1313283002/#ps20001
(title: "2015-08-26T14:32:13 Add comments for printers which are only for
testing")

[commit-bot: I haz the power, 2015-08-26 05:37:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1313283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1313283002/20001

[commit-bot: I haz the power, 2015-08-26 06:46:41]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201207