Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: tools/telemetry/telemetry/web_perf/metrics/smoothness.py

Issue 1313243003: [Telemetry] Introduce SummarizableValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/web_perf/metrics/smoothness.py
diff --git a/tools/telemetry/telemetry/web_perf/metrics/smoothness.py b/tools/telemetry/telemetry/web_perf/metrics/smoothness.py
index 2da287665db5ca667a88f89f8c351618aba25f1c..62201809c70989862110298158335aaa3fdf4125 100644
--- a/tools/telemetry/telemetry/web_perf/metrics/smoothness.py
+++ b/tools/telemetry/telemetry/web_perf/metrics/smoothness.py
@@ -6,6 +6,7 @@ import logging
from telemetry.util import perf_tests_helper
from telemetry.util import statistics
+from telemetry.value import improvement_direction
from telemetry.value import list_of_scalar_values
from telemetry.value import scalar
from telemetry.web_perf.metrics import rendering_stats
@@ -141,22 +142,26 @@ class SmoothnessMetric(timeline_based_metric.TimelineBasedMetric):
page, 'avg_surface_fps', 'fps', avg_surface_fps,
description='Average frames per second as measured by the '
'platform\'s SurfaceFlinger.',
- none_value_reason=none_value_reason),
+ none_value_reason=none_value_reason,
+ improvement_direction=improvement_direction.UP),
scalar.ScalarValue(
page, 'jank_count', 'janks', jank_count,
description='Number of changes in frame rate as measured by the '
'platform\'s SurfaceFlinger.',
- none_value_reason=none_value_reason),
+ none_value_reason=none_value_reason,
+ improvement_direction=improvement_direction.DOWN),
scalar.ScalarValue(
page, 'max_frame_delay', 'vsyncs', max_frame_delay,
description='Largest frame time as measured by the platform\'s '
'SurfaceFlinger.',
- none_value_reason=none_value_reason),
+ none_value_reason=none_value_reason,
+ improvement_direction=improvement_direction.DOWN),
list_of_scalar_values.ListOfScalarValues(
page, 'frame_lengths', 'vsyncs', frame_lengths,
description='Frame time in vsyncs as measured by the platform\'s '
'SurfaceFlinger.',
- none_value_reason=none_value_reason)
+ none_value_reason=none_value_reason,
+ improvement_direction=improvement_direction.DOWN)
)
def _ComputeLatencyMetric(self, page, stats, name, list_of_latency_lists):
@@ -177,11 +182,13 @@ class SmoothnessMetric(timeline_based_metric.TimelineBasedMetric):
scalar.ScalarValue(
page, 'mean_%s' % name, 'ms', mean_latency,
description='Arithmetic mean of the raw %s values' % name,
- none_value_reason=none_value_reason),
+ none_value_reason=none_value_reason,
+ improvement_direction=improvement_direction.DOWN),
scalar.ScalarValue(
page, '%s_discrepancy' % name, 'ms', latency_discrepancy,
description='Discrepancy of the raw %s values' % name,
- none_value_reason=none_value_reason)
+ none_value_reason=none_value_reason,
+ improvement_direction=improvement_direction.DOWN)
)
def _ComputeFirstGestureScrollUpdateLatencies(self, page, stats):
@@ -205,7 +212,8 @@ class SmoothnessMetric(timeline_based_metric.TimelineBasedMetric):
'takes to process the very first gesture scroll update '
'input event. The first scroll gesture can often get '
'delayed by work related to page loading.',
- none_value_reason=none_value_reason)
+ none_value_reason=none_value_reason,
+ improvement_direction=improvement_direction.DOWN)
def _ComputeQueueingDuration(self, page, stats):
"""Returns a Value for the frame queueing durations."""
@@ -229,7 +237,8 @@ class SmoothnessMetric(timeline_based_metric.TimelineBasedMetric):
'ScheduledActionSendBeginMainFrame event in the compositor '
'thread and the corresponding BeginMainFrame event in the '
'main thread.',
- none_value_reason=none_value_reason)
+ none_value_reason=none_value_reason,
+ improvement_direction=improvement_direction.DOWN)
def _ComputeFrameTimeMetric(self, page, stats):
"""Returns Values for the frame time metrics.
@@ -255,15 +264,18 @@ class SmoothnessMetric(timeline_based_metric.TimelineBasedMetric):
page, 'frame_times', 'ms', frame_times,
description='List of raw frame times, helpful to understand the '
'other metrics.',
- none_value_reason=none_value_reason),
+ none_value_reason=none_value_reason,
+ improvement_direction=improvement_direction.DOWN),
scalar.ScalarValue(
page, 'mean_frame_time', 'ms', mean_frame_time,
description='Arithmetic mean of frame times.',
- none_value_reason=none_value_reason),
+ none_value_reason=none_value_reason,
+ improvement_direction=improvement_direction.DOWN),
scalar.ScalarValue(
page, 'percentage_smooth', 'score', percentage_smooth,
description='Percentage of frames that were hitting 60 fps.',
- none_value_reason=none_value_reason)
+ none_value_reason=none_value_reason,
+ improvement_direction=improvement_direction.DOWN)
)
def _ComputeFrameTimeDiscrepancy(self, page, stats):
@@ -286,7 +298,8 @@ class SmoothnessMetric(timeline_based_metric.TimelineBasedMetric):
'is important because even if the mean and 95th '
'percentile are good, one long pause in the middle of an '
'interaction is still bad.',
- none_value_reason=none_value_reason)
+ none_value_reason=none_value_reason,
+ improvement_direction=improvement_direction.DOWN)
def _ComputeMeanPixelsApproximated(self, page, stats):
"""Add the mean percentage of pixels approximated.
@@ -305,7 +318,8 @@ class SmoothnessMetric(timeline_based_metric.TimelineBasedMetric):
page, 'mean_pixels_approximated', 'percent', mean_pixels_approximated,
description='Percentage of pixels that were approximated '
'(checkerboarding, low-resolution tiles, etc.).',
- none_value_reason=none_value_reason)
+ none_value_reason=none_value_reason,
+ improvement_direction=improvement_direction.DOWN)
def _ComputeMeanPixelsCheckerboarded(self, page, stats):
"""Add the mean percentage of pixels checkerboarded.
@@ -330,4 +344,5 @@ class SmoothnessMetric(timeline_based_metric.TimelineBasedMetric):
page, 'mean_pixels_checkerboarded', 'percent',
mean_pixels_checkerboarded,
description='Percentage of pixels that were checkerboarded.',
- none_value_reason=none_value_reason)
+ none_value_reason=none_value_reason,
+ improvement_direction=improvement_direction.DOWN)

Powered by Google App Engine
This is Rietveld 408576698