Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: tools/telemetry/telemetry/web_perf/metrics/memory_timeline.py

Issue 1313243003: [Telemetry] Introduce SummarizableValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/web_perf/metrics/memory_timeline.py
diff --git a/tools/telemetry/telemetry/web_perf/metrics/memory_timeline.py b/tools/telemetry/telemetry/web_perf/metrics/memory_timeline.py
index b691a18c73b2c0f8e541eb8a090230c869adf2d1..c478f486a4f2ac6b51dc4c8927da0e7803df913e 100644
--- a/tools/telemetry/telemetry/web_perf/metrics/memory_timeline.py
+++ b/tools/telemetry/telemetry/web_perf/metrics/memory_timeline.py
@@ -5,6 +5,7 @@
import collections
from telemetry.timeline import memory_dump_event
+from telemetry.value import improvement_direction
from telemetry.value import list_of_scalar_values
from telemetry.web_perf.metrics import timeline_based_metric
@@ -46,7 +47,8 @@ class MemoryTimelineMetric(timeline_based_metric.TimelineBasedMetric):
name='memory_%s_%s' % (metric, process_name),
units='bytes',
values=values,
- none_value_reason=none_reason))
+ none_value_reason=none_reason,
+ improvement_direction=improvement_direction.DOWN))
memory_dumps = filter(HasMmapsDuringInteractions,
model.IterGlobalMemoryDumps())

Powered by Google App Engine
This is Rietveld 408576698