Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: tools/telemetry/telemetry/web_perf/metrics/gpu_timeline.py

Issue 1313243003: [Telemetry] Introduce SummarizableValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/web_perf/metrics/gpu_timeline.py
diff --git a/tools/telemetry/telemetry/web_perf/metrics/gpu_timeline.py b/tools/telemetry/telemetry/web_perf/metrics/gpu_timeline.py
index 6e0333995ec496d10d5b0bdec5c667cd814a4e6b..9737e760204a31f8ef49bf623457effde256589f 100644
--- a/tools/telemetry/telemetry/web_perf/metrics/gpu_timeline.py
+++ b/tools/telemetry/telemetry/web_perf/metrics/gpu_timeline.py
@@ -6,6 +6,7 @@ import math
import sys
from telemetry.timeline import model as model_module
+from telemetry.value import improvement_direction
from telemetry.value import list_of_scalar_values
from telemetry.value import scalar
from telemetry.web_perf.metrics import timeline_based_metric
@@ -24,12 +25,16 @@ TRACKED_GL_CONTEXT_NAME = {'RenderCompositor': 'render_compositor',
class GPUTimelineListOfValues(list_of_scalar_values.ListOfScalarValues):
def __init__(self, page, name, values):
- super(GPUTimelineListOfValues, self).__init__(page, name, 'ms', values)
+ super(GPUTimelineListOfValues, self).__init__(
+ page, name, 'ms', values,
+ improvement_direction=improvement_direction.DOWN)
class GPUTimelineValue(scalar.ScalarValue):
def __init__(self, page, name, value):
- super(GPUTimelineValue, self).__init__(page, name, 'ms', value)
+ super(GPUTimelineValue, self).__init__(
+ page, name, 'ms', value,
+ improvement_direction=improvement_direction.DOWN)
def _CalculateFrameTimes(events_per_frame, event_data_func):

Powered by Google App Engine
This is Rietveld 408576698