Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 131323005: Mark EventToTypeString with ALLOW_UNUSED to fix the Official gtk build. (Closed)

Created:
6 years, 11 months ago by Jeffrey Yasskin
Modified:
6 years, 11 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul
Visibility:
Public.

Description

Mark EventToTypeString with ALLOW_UNUSED to fix the Official gtk build. It's only used inside an UNSHIPPED_TRACE_EVENT1(), which causes: ../../base/message_loop/message_pump_gtk.cc:17:13: error: unused function 'EventToTypeString' [-Werror,-Wunused-function] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244283

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/message_loop/message_pump_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Jeffrey Yasskin
6 years, 11 months ago (2014-01-10 20:15:01 UTC) #1
Elliot Glaysher
lgtm
6 years, 11 months ago (2014-01-10 20:19:47 UTC) #2
willchan no longer on Chromium
LGTM On Fri, Jan 10, 2014 at 12:19 PM, <erg@chromium.org> wrote: > lgtm > > ...
6 years, 11 months ago (2014-01-10 20:32:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/131323005/1
6 years, 11 months ago (2014-01-10 20:54:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/131323005/1
6 years, 11 months ago (2014-01-10 23:32:40 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 00:13:57 UTC) #6
Message was sent while issue was closed.
Change committed as 244283

Powered by Google App Engine
This is Rietveld 408576698