Issue 1313223005: Fix RemoteToLocalSwapOnMainFrameInitializesCoreFrame to not crash on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1313223005: Fix RemoteToLocalSwapOnMainFrameInitializesCoreFrame to not crash on Android. (Closed)

Created:
5 years, 3 months ago by alexmos

Modified:
5 years, 3 months ago

Reviewers:
dcheng

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix RemoteToLocalSwapOnMainFrameInitializesCoreFrame to not crash on Android. BUG=528186 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201831

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -31 lines)			Patch
	M	Source/web/tests/WebFrameTest.cpp	View	1	7 chunks	+3 lines, -31 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

alexmos

Daniel, please take a look. I just changed the test to not use data URLs ...

5 years, 3 months ago (2015-09-04 22:30:10 UTC) #2

dcheng

LGTM (You could probably also use FrameTestHelpers::loadHTMLString)

5 years, 3 months ago (2015-09-04 22:40:41 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313223005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313223005/20001

5 years, 3 months ago (2015-09-04 22:53:06 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-09-04 23:08:54 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201831

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages