Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Unified Diff: Source/platform/graphics/paint/DisplayItem.h

Issue 1313223002: Simplify subtree (now subsequence) caching (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/blink_platform.gypi ('k') | Source/platform/graphics/paint/DisplayItem.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/paint/DisplayItem.h
diff --git a/Source/platform/graphics/paint/DisplayItem.h b/Source/platform/graphics/paint/DisplayItem.h
index 68205d61e09ca3e31ae981e9ecec68dac3257905..0da40fce703c9f7abcd21454f36ee1eb15d5ac22 100644
--- a/Source/platform/graphics/paint/DisplayItem.h
+++ b/Source/platform/graphics/paint/DisplayItem.h
@@ -164,20 +164,9 @@ public:
BeginFixedPositionContainer,
EndFixedPositionContainer,
- CachedSubtreeFirst,
- CachedSubtreePaintPhaseFirst = CachedSubtreeFirst,
- CachedSubtreePaintPhaseLast = CachedSubtreePaintPhaseFirst + PaintPhaseMax,
- CachedSubtreeLast = CachedSubtreePaintPhaseLast,
-
- BeginSubtreeFirst,
- BeginSubtreePaintPhaseFirst = BeginSubtreeFirst,
- BeginSubtreePaintPhaseLast = BeginSubtreePaintPhaseFirst + PaintPhaseMax,
- BeginSubtreeLast = BeginSubtreePaintPhaseLast,
-
- EndSubtreeFirst,
- EndSubtreePaintPhaseFirst = EndSubtreeFirst,
- EndSubtreePaintPhaseLast = EndSubtreePaintPhaseFirst + PaintPhaseMax,
- EndSubtreeLast = EndSubtreePaintPhaseLast,
+ BeginSubsequence,
+ EndSubsequence,
+ CachedSubsequence,
UninitializedType,
TypeLast = UninitializedType
@@ -238,8 +227,8 @@ public:
{
if (isCachedDrawingType(type))
return cachedDrawingTypeToDrawingType(type);
- if (isCachedSubtreeType(type))
- return cachedSubtreeTypeToBeginSubtreeType(type);
+ if (type == CachedSubsequence)
+ return BeginSubsequence;
return type;
}
@@ -319,19 +308,9 @@ public:
DEFINE_PAIRED_CATEGORY_METHODS(Transform3D, transform3D);
- DEFINE_CATEGORY_METHODS(CachedSubtree)
- DEFINE_PAINT_PHASE_CONVERSION_METHOD(CachedSubtree)
- DEFINE_CATEGORY_METHODS(BeginSubtree)
- DEFINE_PAINT_PHASE_CONVERSION_METHOD(BeginSubtree)
- DEFINE_CATEGORY_METHODS(EndSubtree)
- DEFINE_PAINT_PHASE_CONVERSION_METHOD(EndSubtree)
- DEFINE_CONVERSION_METHODS(CachedSubtree, cachedSubtree, BeginSubtree, beginSubtree)
- DEFINE_CONVERSION_METHODS(CachedSubtree, cachedSubtree, EndSubtree, endSubtree)
- DEFINE_CONVERSION_METHODS(BeginSubtree, beginSubtree, EndSubtree, endSubtree)
-
- static bool isCachedType(Type type) { return isCachedDrawingType(type) || isCachedSubtreeType(type); }
+ static bool isCachedType(Type type) { return isCachedDrawingType(type) || type == CachedSubsequence; }
bool isCached() const { return isCachedType(m_type); }
- static bool isCacheableType(Type type) { return isDrawingType(type) || isBeginSubtreeType(type); }
+ static bool isCacheableType(Type type) { return isDrawingType(type) || type == BeginSubsequence; }
bool isCacheable() const { return !skippedCache() && isCacheableType(m_type); }
virtual bool isBegin() const { return false; }
« no previous file with comments | « Source/platform/blink_platform.gypi ('k') | Source/platform/graphics/paint/DisplayItem.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698