Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1313203003: Remove include of stdlib.h from SkTypes.h. (Closed)

Created:
5 years, 4 months ago by bungeman-skia
Modified:
5 years, 3 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove include of stdlib.h from SkTypes.h. Unfortunately, immintrin.h (which is also included by SkTypes) includes xmmintrin.h which includes mm_malloc.h which includes stdlib.h for malloc even though, from the implementation, it is difficult to see why. Fortunately, arm_neon.h does not seem to be involved in such shenanigans, so building for Android will keep things sane. TBR=reed@google.com Doesn't change Skia API, just moves an include. Committed: https://skia.googlesource.com/skia/+/60e0fee6d4acff638ccc9670c4055aced529a7a0

Patch Set 1 #

Patch Set 2 : Build with Android. #

Patch Set 3 : Remove unwanted temp. #

Patch Set 4 : Clean up qsort conversion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -31 lines) Patch
M bench/SortBench.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M bench/nanobench.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M dm/DM.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkTypes.h View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SamplePath.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkGraphics.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkRegion_path.cpp View 1 2 3 3 chunks +8 lines, -7 lines 0 comments Download
M src/core/SkResourceCache.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkTime.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pathops/SkOpAngle.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M src/pathops/SkOpSpan.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsDebug.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsTypes.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkEventTracer.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/utils/SkParse.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/utils/SkRTConf.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/PathOpsAngleTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PathOpsCubicIntersectionTest.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/PathOpsQuadLineIntersectionThreadedTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsSkpClipTest.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/RTConfRegistryTest.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/SortTest.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/Time.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/PictureRenderingFlags.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/PictureResultsWriter.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/dump_record.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/flags/SkCommandLineFlags.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/flatten.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/lua/lua_app.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/lua/lua_pictures.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/render_pictures_main.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
M tools/skdiff_main.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/skpdiff/SkDifferentPixelsMetric_cpu.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
M tools/skpmaker.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313203003/1
5 years, 4 months ago (2015-08-25 20:47:06 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/2891)
5 years, 4 months ago (2015-08-25 20:48:38 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313203003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313203003/60001
5 years, 4 months ago (2015-08-25 22:22:00 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-25 22:27:12 UTC) #8
bungeman-skia
5 years, 4 months ago (2015-08-25 22:31:13 UTC) #10
mtklein
lgtm (malloc and free are declared in stdlib.h, no?)
5 years, 3 months ago (2015-08-26 12:14:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313203003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313203003/60001
5 years, 3 months ago (2015-08-26 12:15:06 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 12:15:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/60e0fee6d4acff638ccc9670c4055aced529a7a0

Powered by Google App Engine
This is Rietveld 408576698