Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: BUILD.gn

Issue 1313193002: Pass -Wno-unused-funciton, -Wno-sign-compare in non-clang gn builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/libvpx.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/arm.gni") 5 import("//build/config/arm.gni")
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 import("//build/config/chrome_build.gni") 7 import("//build/config/chrome_build.gni")
8 import("//third_party/libvpx/libvpx_srcs.gni") 8 import("//third_party/libvpx/libvpx_srcs.gni")
9 import("//third_party/yasm/yasm_assemble.gni") 9 import("//third_party/yasm/yasm_assemble.gni")
10 10
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 config("libvpx_warnings") { 50 config("libvpx_warnings") {
51 if (is_clang) { 51 if (is_clang) {
52 cflags = [ 52 cflags = [
53 # libvpx heavily relies on implicit enum casting. 53 # libvpx heavily relies on implicit enum casting.
54 "-Wno-conversion", 54 "-Wno-conversion",
55 # libvpx does `if ((a == b))` in some places. 55 # libvpx does `if ((a == b))` in some places.
56 "-Wno-parentheses-equality", 56 "-Wno-parentheses-equality",
57 # libvpx has many static functions in header, which trigger this warning. 57 # libvpx has many static functions in header, which trigger this warning.
58 "-Wno-unused-function", 58 "-Wno-unused-function",
59 ] 59 ]
60 } else if (!is_win) {
61 cflags = [ "-Wno-unused-function", "-Wno-sign-compare" ]
60 } 62 }
61 } 63 }
62 64
63 # This config is applied to targets that depend on libvpx. 65 # This config is applied to targets that depend on libvpx.
64 config("libvpx_external_config") { 66 config("libvpx_external_config") {
65 include_dirs = [ 67 include_dirs = [
66 "//third_party/libvpx/source/libvpx", 68 "//third_party/libvpx/source/libvpx",
67 ] 69 ]
68 } 70 }
69 71
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 } 258 }
257 if (is_android) { 259 if (is_android) {
258 deps += [ "//third_party/android_tools:cpu_features" ] 260 deps += [ "//third_party/android_tools:cpu_features" ]
259 } 261 }
260 if (current_cpu == "arm") { 262 if (current_cpu == "arm") {
261 deps += [ ":libvpx_assembly_arm" ] 263 deps += [ ":libvpx_assembly_arm" ]
262 } 264 }
263 265
264 public_configs = [ ":libvpx_external_config" ] 266 public_configs = [ ":libvpx_external_config" ]
265 } 267 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698