Dont blur currently focused element on clicking scrollbar.

Dont blur currently focused element on clicking scrollbar.

Dont blur currently focused element on clicking scrollbar on
root-layer-scrolls. If targetedEvent hitTestResult's scrollbar's
scrollableArea is same as contentLayoutObject scrollableArea then
return false from EventHandler::handleMouseFocus.

TESTED=scrollbars/scrollbar-iframe-click-does-not-blur-content.html
now passes with root layer scrolling

BUG=522389
Committed: https://crrev.com/6634c6177b68f96d510087442abf49ee618d285f
Cr-Commit-Position: refs/heads/master@{#351709}

[MuVen, 2015-08-28 10:11:55]

sataya.m@samsung.com changed reviewers:
+ skobes@chromium.org

[MuVen, 2015-09-07 09:27:57]

Hi Skobes,

PTAL.

Thanks,

[skobes, 2015-09-12 02:31:02]

I'd rather solve this in EventHandler::handleMouseFocus if possible.  Can we
check in there for a click on the LayoutView's scrollbar, e.g.
targetedEvent.hitTestResult().scrollbar()->scrollableArea() ==
m_frame->contentLayoutObject()->scrollableArea()?

That way FrameView::scrollbarAtFramePoint and
FrameView::scrollbarAtRootFramePoint can be deleted post-RLS.

[MuVen, 2015-09-14 12:32:28]

On 2015/09/12 02:31:02, skobes wrote:
> I'd rather solve this in EventHandler::handleMouseFocus if possible.  Can we
> check in there for a click on the LayoutView's scrollbar, e.g.
> targetedEvent.hitTestResult().scrollbar()->scrollableArea() ==
> m_frame->contentLayoutObject()->scrollableArea()?
> 
> That way FrameView::scrollbarAtFramePoint and
> FrameView::scrollbarAtRootFramePoint can be deleted post-RLS.

I have checked your comment, targetedEvent.hitTestResult().scrollbar()
is (nil) in case of click on inner-div scrollbars but returns scrollbar
for main-frame scrollbars. Shall i raise an issue for the same ?

[skobes, 2015-09-14 21:34:09]

On 2015/09/14 12:32:28, MuVen wrote:
> On 2015/09/12 02:31:02, skobes wrote:
> > I'd rather solve this in EventHandler::handleMouseFocus if possible.  Can we
> > check in there for a click on the LayoutView's scrollbar, e.g.
> > targetedEvent.hitTestResult().scrollbar()->scrollableArea() ==
> > m_frame->contentLayoutObject()->scrollableArea()?
> > 
> > That way FrameView::scrollbarAtFramePoint and
> > FrameView::scrollbarAtRootFramePoint can be deleted post-RLS.
> 
> I have checked your comment, targetedEvent.hitTestResult().scrollbar()
> is (nil) in case of click on inner-div scrollbars but returns scrollbar
> for main-frame scrollbars. Shall i raise an issue for the same ?

Yes, that's somewhat surprising.  I thought HitTestResult::m_scrollbar would be
set by DeprecatedPaintLayerScrollableArea::hitTestOverflowControls.

[MuVen, 2015-09-29 14:03:27]

Skobes, PTAL.

[skobes, 2015-09-30 17:38:40]

lgtm

[MuVen, 2015-09-30 17:48:01]

The CQ bit was checked by sataya.m@samsung.com

[commit-bot: I haz the power, 2015-09-30 17:49:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1313183006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1313183006/20001

[commit-bot: I haz the power, 2015-09-30 18:48:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-30 18:48:25]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[MuVen, 2015-10-01 01:52:43]

The CQ bit was checked by sataya.m@samsung.com

[commit-bot: I haz the power, 2015-10-01 01:53:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1313183006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1313183006/20001

[commit-bot: I haz the power, 2015-10-01 02:27:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-01 02:28:19]

Patchset 2 (id:??) landed as
https://crrev.com/6634c6177b68f96d510087442abf49ee618d285f
Cr-Commit-Position: refs/heads/master@{#351709}