Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1313083005: Oilpan: Simple clean-up in FrameLoaderClientImplTest. (Closed)

Created:
5 years, 3 months ago by Yuta Kitamura
Modified:
5 years, 3 months ago
Reviewers:
haraken, oilpan-reviews, sof
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Simple clean-up in FrameLoaderClientImplTest. An accessor function called frameLoaderClientImpl(), added in https://codereview.chromium.org/1314703003/, was actually not necessary. BUG=509911 R=haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201210

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M Source/web/tests/FrameLoaderClientImplTest.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yuta Kitamura
5 years, 3 months ago (2015-08-26 06:35:37 UTC) #1
haraken
LGTM
5 years, 3 months ago (2015-08-26 06:55:59 UTC) #2
sof
thanks, lgtm.
5 years, 3 months ago (2015-08-26 06:57:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313083005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313083005/1
5 years, 3 months ago (2015-08-26 07:04:34 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 07:52:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201210

Powered by Google App Engine
This is Rietveld 408576698