Allow more scavenges during idle times by pushing down the idle new space limit.

src/heap/gc-idle-time-handler.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/heap/gc-idle-time-handler.h"
 
 #include "src/flags.h"
 #include "src/heap/gc-tracer.h"
 #include "src/utils.h"
 
@@ skipping 101 matching lines @@
 
 
 bool GCIdleTimeHandler::ShouldDoScavenge(
     size_t idle_time_in_ms, size_t new_space_size, size_t used_new_space_size,
     size_t scavenge_speed_in_bytes_per_ms,
     size_t new_space_allocation_throughput_in_bytes_per_ms) {
   if (idle_time_in_ms >= kMinBackgroundIdleTime) {
     // It is better to do full GC for the background tab.
     return false;
   }
-  size_t new_space_allocation_limit =
-      kMaxScheduledIdleTime * scavenge_speed_in_bytes_per_ms;
+
+  // Calculates how much memory are we able to scavenge in
+  // kMaxFrameRenderingIdleTime ms. If scavenge_speed_in_bytes_per_ms is 0 we
+  // will take care of this later.
+  size_t idle_new_space_allocation_limit =
+      kMaxFrameRenderingIdleTime * scavenge_speed_in_bytes_per_ms;
 
   // If the limit is larger than the new space size, then scavenging used to be
   // really fast. We can take advantage of the whole new space.
-  if (new_space_allocation_limit > new_space_size) {
-    new_space_allocation_limit = new_space_size;
+  if (idle_new_space_allocation_limit > new_space_size) {
+    idle_new_space_allocation_limit = new_space_size;
   }
 
   // We do not know the allocation throughput before the first scavenge.
   // TODO(hpayer): Estimate allocation throughput before the first scavenge.
   if (new_space_allocation_throughput_in_bytes_per_ms > 0) {
     // We have to trigger scavenge before we reach the end of new space.
     size_t adjust_limit = new_space_allocation_throughput_in_bytes_per_ms *
                           kTimeUntilNextIdleEvent;
-    if (adjust_limit > new_space_allocation_limit) {
-      new_space_allocation_limit = 0;
+    if (adjust_limit > idle_new_space_allocation_limit) {
+      idle_new_space_allocation_limit = 0;
     } else {
-      new_space_allocation_limit -= adjust_limit;
+      idle_new_space_allocation_limit -= adjust_limit;
     }
   }
 
-  if (new_space_allocation_throughput_in_bytes_per_ms <
-      kLowAllocationThroughput) {
-    new_space_allocation_limit =
-        Min(new_space_allocation_limit,
-            static_cast<size_t>(new_space_size * kConservativeTimeRatio));
-  }
-
   // The allocated new space limit to trigger a scavange has to be at least
   // kMinimumNewSpaceSizeToPerformScavenge.
-  if (new_space_allocation_limit < kMinimumNewSpaceSizeToPerformScavenge) {
-    new_space_allocation_limit = kMinimumNewSpaceSizeToPerformScavenge;
+  if (idle_new_space_allocation_limit < kMinimumNewSpaceSizeToPerformScavenge) {
+    idle_new_space_allocation_limit = kMinimumNewSpaceSizeToPerformScavenge;
   }
 
+  // Set an initial scavenge speed if it is unknown.
   if (scavenge_speed_in_bytes_per_ms == 0) {
     scavenge_speed_in_bytes_per_ms = kInitialConservativeScavengeSpeed;
   }
 
-  if (new_space_allocation_limit <= used_new_space_size) {
+  // We apply a max factor to the new space size to make sure that a slowly
+  // allocating application still leaves enough of wiggle room to schedule a
+  // scavenge.
+  size_t max_limit;
+  const double kMaxNewSpaceSizeFactorLongIdleTimes = 0.5;
+  const double kMaxNewSpaceSizeFactorShortIdleTimes = 0.8;
+  if (idle_time_in_ms > kMaxFrameRenderingIdleTime) {
+    max_limit = static_cast<size_t>(new_space_size *
+                                    kMaxNewSpaceSizeFactorLongIdleTimes);
+  } else {
+    max_limit = static_cast<size_t>(new_space_size *
+                                    kMaxNewSpaceSizeFactorShortIdleTimes);
+  }
+  idle_new_space_allocation_limit =
+      Min(idle_new_space_allocation_limit, max_limit);
+
+  // We perform a scavenge if we are over the idle new space limit and
+  // a scavenge fits into the given idle time bucket.
+  if (idle_new_space_allocation_limit <= used_new_space_size) {
     if (used_new_space_size / scavenge_speed_in_bytes_per_ms <=
         idle_time_in_ms) {
       return true;
     }
   }
   return false;
 }
 
 
 bool GCIdleTimeHandler::ShouldDoMarkCompact(
@@ skipping 97 matching lines @@
 
   size_t step_size = EstimateMarkingStepSize(
       static_cast<size_t>(kIncrementalMarkingStepTimeInMs),
       heap_state.incremental_marking_speed_in_bytes_per_ms);
   return GCIdleTimeAction::IncrementalMarking(step_size);
 }
 
 
 }
 }