Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

Issue 1313043003: Fix crash on J,K while swiping on custom tabs title (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated isSwipeEnabled Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
index 8bf6d69d2f654b67ad4b24c774e90356a1552a77..79b099f68f56f88d7deda5b55f5765690c3e4ffa 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
@@ -445,6 +445,7 @@ public class LayoutManagerDocument extends LayoutManager
public boolean isSwipeEnabled(ScrollDirection direction) {
FullscreenManager manager = mHost.getFullscreenManager();
if (getActiveLayout() != mStaticLayout
+ || !FeatureUtilities.isDocumentModeEligible(mHost.getContext())
David Trainor- moved to gerrit 2015/09/01 22:23:50 Now that I think about it, I think this is suppose
Yusuf 2015/09/01 22:29:42 Yes, we are in tabbed mode since it is J or K. It
David Trainor- moved to gerrit 2015/09/01 23:23:53 Ok that works for me and makes sense! :)
|| !DeviceClassManager.enableToolbarSwipe(
FeatureUtilities.isDocumentMode(mHost.getContext()))
|| (manager != null && manager.getPersistentFullscreenMode())) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698