Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1313023002: [heap] Report proper GC type in prologue/eplilogue callbacks. (Closed)

Created:
5 years, 3 months ago by Michael Lippautz
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Report proper GC type in prologue/eplilogue callbacks. Followup to https://codereview.chromium.org/1288683005 BUG=chromium:521946 LOG=N Committed: https://crrev.com/052a4cf135af30a9604151f4e19af2961d8a0708 Cr-Commit-Position: refs/heads/master@{#30345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M src/heap/heap.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Michael Lippautz
Is the blink counterpart ready?
5 years, 3 months ago (2015-08-25 08:40:03 UTC) #2
haraken
On 2015/08/25 08:40:03, Michael Lippautz wrote: > Is the blink counterpart ready? Yes, the blink ...
5 years, 3 months ago (2015-08-25 08:40:54 UTC) #3
Michael Lippautz
Hannes, pretty please
5 years, 3 months ago (2015-08-25 08:42:46 UTC) #5
Hannes Payer (out of office)
lgtm
5 years, 3 months ago (2015-08-25 08:50:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313023002/1
5 years, 3 months ago (2015-08-25 08:52:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-25 09:21:59 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-25 09:22:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/052a4cf135af30a9604151f4e19af2961d8a0708
Cr-Commit-Position: refs/heads/master@{#30345}

Powered by Google App Engine
This is Rietveld 408576698