Issue 1313013008: [sqlite] Fix BUILD.gn osx/win breakage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1313013008: [sqlite] Fix BUILD.gn osx/win breakage. (Closed)

Created:
5 years, 3 months ago by Scott Hess - ex-Googler

Modified:
5 years, 3 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Superseded by https://codereview.chromium.org/1325513002/ [sqlite] Fix BUILD.gn osx/win breakage. https://crrev.com/4ec68d9ad2d3e0c74967a17946c8bf7ed4450f73 broke gn setting exported defines on Windows, setting required libraries on osx. Also fixed gn formatting presubmit complaint. BUG=489444

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -13 lines)			Patch
	M	third_party/sqlite/BUILD.gn	View		3 chunks	+9 lines, -13 lines	1 comment	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Scott Hess - ex-Googler

Since you pointed out the build breakage...

5 years, 3 months ago (2015-08-28 17:40:55 UTC) #2

Nico

5 years, 3 months ago (2015-08-28 17:41:54 UTC) #3

lgtm

https://codereview.chromium.org/1313013008/diff/1/third_party/sqlite/BUILD.gn
File third_party/sqlite/BUILD.gn (right):

https://codereview.chromium.org/1313013008/diff/1/third_party/sqlite/BUILD.gn...
third_party/sqlite/BUILD.gn:99: "CoreServices.framework",
whoops

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages