Import Mozilla's IndexedDB getAll/getAllKeys tests

Import Mozilla's IndexedDB getAll/getAllKeys tests

BUG=457450
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201171

[jsbell, 2015-08-25 18:17:52]

jsbell@chromium.org changed reviewers:
+ cmumford@chromium.org

[jsbell, 2015-08-25 18:17:52]

cmumford@ - please take a look?

[cmumford, 2015-08-25 18:42:31]

https://codereview.chromium.org/1312983006/diff/20001/LayoutTests/storage/ind...
File LayoutTests/storage/indexeddb/mozilla/resources/test_index_getAll.js
(right):

https://codereview.chromium.org/1312983006/diff/20001/LayoutTests/storage/ind...
LayoutTests/storage/indexeddb/mozilla/resources/test_index_getAll.js:2: // *
http://mxr.mozilla.org/mozilla-central/source/dom/indexedDB/test/unit/test_in...
This URL doesn't match this file does it?

Also, where is test_index_getAllObjects.js?

[jsbell, 2015-08-25 18:52:07]

On 2015/08/25 18:42:31, cmumford wrote:
>
https://codereview.chromium.org/1312983006/diff/20001/LayoutTests/storage/ind...
> File LayoutTests/storage/indexeddb/mozilla/resources/test_index_getAll.js
> (right):
> 
>
https://codereview.chromium.org/1312983006/diff/20001/LayoutTests/storage/ind...
> LayoutTests/storage/indexeddb/mozilla/resources/test_index_getAll.js:2: // *
>
http://mxr.mozilla.org/mozilla-central/source/dom/indexedDB/test/unit/test_in...
> This URL doesn't match this file does it?
> 
> Also, where is test_index_getAllObjects.js?

Whoah, duh, I mucked up the names and links on import. Trying again...

[cmumford, 2015-08-25 20:22:30]

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
File LayoutTests/storage/indexeddb/mozilla/resources/test_getAll.js (right):

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
LayoutTests/storage/indexeddb/mozilla/resources/test_getAll.js:2: // *
http://mxr.mozilla.org/mozilla-central/source/dom/indexedDB/test/unit/test_ge...
What do you think about changing force to raw?

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
LayoutTests/storage/indexeddb/mozilla/resources/test_getAll.js:7: // *
testGenerator.send() -> testGenerator.next()
You didn't add testGenerator.send() -> testGenerator.next() in this file.

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
File
LayoutTests/storage/indexeddb/mozilla/resources/test_objectStore_getAllKeys.js
(right):

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
LayoutTests/storage/indexeddb/mozilla/resources/test_objectStore_getAllKeys.js:6:
// * this.window -> window
No testGenerator changes here either.

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
File LayoutTests/storage/indexeddb/mozilla/test_index_getAllObjects-expected.txt
(right):

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
LayoutTests/storage/indexeddb/mozilla/test_index_getAllObjects-expected.txt:1:
IDBIndex.getAll()
IDBIndex.getAllObjects()

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
File LayoutTests/storage/indexeddb/mozilla/test_index_getAllObjects.html
(right):

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
LayoutTests/storage/indexeddb/mozilla/test_index_getAllObjects.html:2:
<title>IDBIndex.getAll()</title>
getAllObjects()

[jsbell, 2015-08-25 20:45:06]

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
File LayoutTests/storage/indexeddb/mozilla/resources/test_getAll.js (right):

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
LayoutTests/storage/indexeddb/mozilla/resources/test_getAll.js:2: // *
http://mxr.mozilla.org/mozilla-central/source/dom/indexedDB/test/unit/test_ge...
On 2015/08/25 20:22:30, cmumford wrote:
> What do you think about changing force to raw?

I'll just drop the query string entirely. (The ?force=1 was in the links I was
sent via email, but doesn't seem necessary)

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
LayoutTests/storage/indexeddb/mozilla/resources/test_getAll.js:7: // *
testGenerator.send() -> testGenerator.next()
On 2015/08/25 20:22:30, cmumford wrote:
> You didn't add testGenerator.send() -> testGenerator.next() in this file.

Removed.

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
File
LayoutTests/storage/indexeddb/mozilla/resources/test_objectStore_getAllKeys.js
(right):

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
LayoutTests/storage/indexeddb/mozilla/resources/test_objectStore_getAllKeys.js:6:
// * this.window -> window
On 2015/08/25 20:22:30, cmumford wrote:
> No testGenerator changes here either.

Done.

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
File LayoutTests/storage/indexeddb/mozilla/test_index_getAllObjects-expected.txt
(right):

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
LayoutTests/storage/indexeddb/mozilla/test_index_getAllObjects-expected.txt:1:
IDBIndex.getAll()
On 2015/08/25 20:22:30, cmumford wrote:
> IDBIndex.getAllObjects()

Comes from the title of the test (see comment in .html)

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
File LayoutTests/storage/indexeddb/mozilla/test_index_getAllObjects.html
(right):

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
LayoutTests/storage/indexeddb/mozilla/test_index_getAllObjects.html:2:
<title>IDBIndex.getAll()</title>
On 2015/08/25 20:22:30, cmumford wrote:
> getAllObjects()

No such function; it's testing getAll(), it's just that the filename (per
upstream) is weird:

* test_index_getAll is testing IDBIndex.getAllKeys()
* test_index_getAllObjects is testing IDBIndex.getAll()

[cmumford, 2015-08-25 20:47:00]

lgtm

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
File LayoutTests/storage/indexeddb/mozilla/test_index_getAllObjects.html
(right):

https://codereview.chromium.org/1312983006/diff/60001/LayoutTests/storage/ind...
LayoutTests/storage/indexeddb/mozilla/test_index_getAllObjects.html:2:
<title>IDBIndex.getAll()</title>
On 2015/08/25 20:45:06, jsbell wrote:
> On 2015/08/25 20:22:30, cmumford wrote:
> > getAllObjects()
> 
> No such function; it's testing getAll(), it's just that the filename (per
> upstream) is weird:
> 
> * test_index_getAll is testing IDBIndex.getAllKeys()
> * test_index_getAllObjects is testing IDBIndex.getAll()
> 

haha - I should know that huh?

[jsbell, 2015-08-25 20:47:29]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2015-08-25 20:47:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312983006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312983006/80001

[commit-bot: I haz the power, 2015-08-25 21:46:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 21:46:53]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jsbell, 2015-08-25 23:18:43]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2015-08-25 23:18:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312983006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312983006/80001

[commit-bot: I haz the power, 2015-08-26 00:13:49]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201171