Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1312983003: Apply CSS Animations on color properties to visited and unvisited link computed styles (Closed)

Created:
5 years, 4 months ago by alancutter (OOO until 2018)
Modified:
5 years, 4 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Apply CSS Animations on color properties to visited and unvisited link computed styles We must apply color animations to both the visited and unvisited computed style colors when inside links as the animation must apply in either case. BUG=506898 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201185

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix test #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
A LayoutTests/animations/visited-link-color-animation.html View 1 1 chunk +45 lines, -0 lines 0 comments Download
A LayoutTests/animations/visited-link-color-animation-expected.html View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
alancutter (OOO until 2018)
5 years, 4 months ago (2015-08-25 04:23:35 UTC) #2
Timothy Loh
https://codereview.chromium.org/1312983003/diff/40001/Source/core/css/resolver/StyleResolver.cpp File Source/core/css/resolver/StyleResolver.cpp (right): https://codereview.chromium.org/1312983003/diff/40001/Source/core/css/resolver/StyleResolver.cpp#newcode922 Source/core/css/resolver/StyleResolver.cpp:922: state.setApplyPropertyToRegularStyle(true); ASSERT(state.applyPropertyToRegularStyle())
5 years, 4 months ago (2015-08-25 08:29:28 UTC) #3
alancutter (OOO until 2018)
On 2015/08/25 at 08:29:28, timloh wrote: > https://codereview.chromium.org/1312983003/diff/40001/Source/core/css/resolver/StyleResolver.cpp > File Source/core/css/resolver/StyleResolver.cpp (right): > > https://codereview.chromium.org/1312983003/diff/40001/Source/core/css/resolver/StyleResolver.cpp#newcode922 ...
5 years, 4 months ago (2015-08-25 08:32:37 UTC) #4
Timothy Loh
On 2015/08/25 08:32:37, alancutter wrote: > On 2015/08/25 at 08:29:28, timloh wrote: > > > ...
5 years, 4 months ago (2015-08-25 09:21:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312983003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312983003/60001
5 years, 4 months ago (2015-08-25 09:32:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/73396)
5 years, 4 months ago (2015-08-25 09:44:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312983003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312983003/80001
5 years, 4 months ago (2015-08-26 00:37:38 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-26 02:34:45 UTC) #13
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201185

Powered by Google App Engine
This is Rietveld 408576698