Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1534)

Unified Diff: Source/platform/heap/Visitor.h

Issue 1312963002: Fix race at GCInfo::index. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@trest
Patch Set: Remove static locals, leave GCInfo unsafe. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/heap/GCInfo.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/Visitor.h
diff --git a/Source/platform/heap/Visitor.h b/Source/platform/heap/Visitor.h
index cb85371e7f8c2c1347d5740549ca466a4c739794..1a50d167289ab6dbd5e7863c176fbfc1777adecb 100644
--- a/Source/platform/heap/Visitor.h
+++ b/Source/platform/heap/Visitor.h
@@ -42,7 +42,6 @@
#include "wtf/HashMap.h"
#include "wtf/HashTraits.h"
#include "wtf/InstanceCounter.h"
-#include "wtf/Threading.h"
#include "wtf/TypeTraits.h"
#include "wtf/text/WTFString.h"
@@ -387,11 +386,9 @@ private:
template<typename T>
struct TypenameStringTrait {
- // This method is not thread safe.
- static const String& get()
+ static const String get()
{
- AtomicallyInitializedStaticReference(AtomicString, typenameString, new AtomicString(WTF::extractTypeNameFromFunctionName(WTF::extractNameFunction<T>())));
- return typenameString;
+ return WTF::extractTypeNameFromFunctionName(WTF::extractNameFunction<T>());
}
};
« no previous file with comments | « Source/platform/heap/GCInfo.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698