Check if the issue owner is in the AUTHORS file in PRESUBMIT.py

PRESUBMIT.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 """Top-level presubmit script for Skia.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
+import fnmatch
 import os
 import re
 import sys
+import traceback
 
 
 REVERT_CL_SUBJECT_PREFIX = 'Revert '
 
 SKIA_TREE_STATUS_URL = 'http://skia-tree-status.appspot.com'
 
 PUBLIC_API_OWNERS = (
     'reed@chromium.org',
     'reed@google.com',
     'bsalomon@chromium.org',
     'bsalomon@google.com',
 )
 
+AUTHORS_FILE_NAME = 'AUTHORS'
+
 
 def _CheckChangeHasEol(input_api, output_api, source_file_filter=None):
   """Checks that files end with atleast one \n (LF)."""
   eof_files = []
   for f in input_api.AffectedSourceFiles(source_file_filter):
     contents = input_api.ReadFile(f, 'rb')
     # Check that the file ends in atleast one newline character.
     if len(contents) > 1 and contents[-1:] != '\n':
       eof_files.append(f.LocalPath())
 
@@ skipping 61 matching lines @@
         SKIA_TREE_STATUS_URL + '/current-sheriff')
     sheriff_details = input_api.json.loads(connection.read())
     if sheriff_details:
       tree_status_results[0]._message += (
           '\n\nPlease contact the current Skia sheriff (%s) if you are trying '
           'to submit a build fix\nand do not know how to submit because the '
           'tree is closed') % sheriff_details['username']
   return tree_status_results
 
 
+def _CheckOwnerIsInAuthorsFile(input_api, output_api):
+  results = []
+  issue = input_api.change.issue
+  if issue and input_api.rietveld:
+    issue_properties = input_api.rietveld.get_issue_properties( 
+        issue=int(issue), messages=False)
+    owner_email = issue_properties['owner_email']
+
+    try:
+      authors_content = ''
+      for line in open(AUTHORS_FILE_NAME):
+        if not line.startswith('#'):
+          authors_content += line
+      email_fnmatches = re.findall('<(.*)>', authors_content)
+      for email_fnmatch in email_fnmatches:
+        if fnmatch.fnmatch(owner_email, email_fnmatch):
+          # Found a match, the user is in the AUTHORS file break out of the loop
+          break
+      else:
+        # TODO(rmistry): Remove the below CLA messaging once a CLA checker has
+        # been added to the CQ.
+        results.append(
+          output_api.PresubmitError(
+            'The email %s is not in Skia\'s AUTHORS file.\n'
+            'Issue owner, this CL must include an addition to the Skia AUTHORS '
+            'file.\n'
+            'Googler reviewers, please check that the AUTHORS entry '
+            'corresponds to an email address in http://goto/cla-signers. If it '
+            'does not then ask the issue owner to sign the CLA at '
+            'http://code.google.com/legal/individual-cla-v1.0.html '
+            '(individual) or '
+            'http://code.google.com/legal/corporate-cla-v1.0.html (corporate).'
+            % owner_email)) 

[borenet, 2014/02/03 13:54:00]

I think this message could be worded more clearly, but I don't have a good
suggestion...

+    except IOError:
+      # Do not fail if authors file cannot be found.
+      traceback.print_exc()
+      input_api.logging.error('AUTHORS file not found!')
+
+  return results
+
+
 def _CheckLGTMsForPublicAPI(input_api, output_api):
   """Check LGTMs for public API changes.
 
   For public API files make sure there is an LGTM from the list of owners in
   PUBLIC_API_OWNERS.
   """
   results = []
   requires_owner_check = False
   for affected_svn_file in input_api.AffectedFiles():
     affected_file_path = affected_svn_file.AbsoluteLocalPath()
@@ skipping 42 matching lines @@
   * Ensures that the Skia tree is open in
     http://skia-tree-status.appspot.com/. Shows a warning if it is in 'Caution'
     state and an error if it is in 'Closed' state.
   """
   results = []
   results.extend(_CommonChecks(input_api, output_api))
   results.extend(
       _CheckTreeStatus(input_api, output_api, json_url=(
           SKIA_TREE_STATUS_URL + '/banner-status?format=json')))
   results.extend(_CheckLGTMsForPublicAPI(input_api, output_api))
+  results.extend(_CheckOwnerIsInAuthorsFile(input_api, output_api))
   return results