Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1312923003: Fix test launcher crash on non-UTF-8 output snippets (Closed)

Created:
5 years, 3 months ago by Paweł Hajdan Jr.
Modified:
5 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix test launcher crash on non-UTF-8 output snippets BUG=525484 Committed: https://crrev.com/cd6ee1a8479878323e7a3e54b6588038428876b2 Cr-Commit-Position: refs/heads/master@{#346098}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M base/test/launcher/test_results_tracker.cc View 1 chunk +14 lines, -10 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
Paweł Hajdan Jr.
5 years, 3 months ago (2015-08-27 14:49:24 UTC) #2
sky
LGTM
5 years, 3 months ago (2015-08-27 16:51:24 UTC) #3
sky
https://codereview.chromium.org/1312923003/diff/1/base/test/launcher/test_results_tracker.cc File base/test/launcher/test_results_tracker.cc (right): https://codereview.chromium.org/1312923003/diff/1/base/test/launcher/test_results_tracker.cc#newcode273 base/test/launcher/test_results_tracker.cc:273: "<non-UTF-8 snippet, see output_snippet_base64>"); Actually, one question here, can ...
5 years, 3 months ago (2015-08-27 16:51:56 UTC) #4
Paweł Hajdan Jr.
https://codereview.chromium.org/1312923003/diff/1/base/test/launcher/test_results_tracker.cc File base/test/launcher/test_results_tracker.cc (right): https://codereview.chromium.org/1312923003/diff/1/base/test/launcher/test_results_tracker.cc#newcode273 base/test/launcher/test_results_tracker.cc:273: "<non-UTF-8 snippet, see output_snippet_base64>"); On 2015/08/27 at 16:51:56, sky ...
5 years, 3 months ago (2015-08-28 08:04:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312923003/1
5 years, 3 months ago (2015-08-28 08:04:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 08:09:01 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 08:09:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd6ee1a8479878323e7a3e54b6588038428876b2
Cr-Commit-Position: refs/heads/master@{#346098}

Powered by Google App Engine
This is Rietveld 408576698