Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1312903015: Subzero: Fix MINIMAL build error. (Closed)

Created:
5 years, 3 months ago by Jim Stichnoth
Modified:
5 years, 3 months ago
Reviewers:
ascull
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix MINIMAL build error. A NOASSERT/MINIMAL build complains that private field Func is unused, which turned out to be true because of shadowing. BUG= none R=ascull@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=8f98cdd255a1e1f07032e660d928a69a4ebece5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/IceLoopAnalyzer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Jim Stichnoth
5 years, 3 months ago (2015-09-04 16:17:15 UTC) #2
ascull
lgtm
5 years, 3 months ago (2015-09-04 16:19:13 UTC) #4
Jim Stichnoth
5 years, 3 months ago (2015-09-04 16:21:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8f98cdd255a1e1f07032e660d928a69a4ebece5b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698