Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2143)

Unified Diff: Source/devtools/front_end/timeline/TimelineModel.js

Issue 1312903005: DevTools: Make functions on timeline tree view point to the right source location (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineModel.js
diff --git a/Source/devtools/front_end/timeline/TimelineModel.js b/Source/devtools/front_end/timeline/TimelineModel.js
index f56571beaca93a2f7be3daf91deda39217b872c2..d242cac7679a92d5fd47f3b0b6ad1d5ea5295c1d 100644
--- a/Source/devtools/front_end/timeline/TimelineModel.js
+++ b/Source/devtools/front_end/timeline/TimelineModel.js
@@ -1484,8 +1484,8 @@ WebInspector.TimelineModel.buildTopDownTree = function(events, startTime, endTim
return false;
if (WebInspector.TracingModel.isAsyncPhase(e.phase))
return false;
- for (var filter of filters) {
- if (!filter.accept(e))
+ for (var i = 0, l = filters.length; i < l; ++i) {
yurys 2015/08/29 00:44:18 did it prove to be slow?
alph 2015/09/01 21:38:55 Yes, for-of still disables optimization and the fi
+ if (!filters[i].accept(e))
return false;
}
return true;

Powered by Google App Engine
This is Rietveld 408576698