DevTools: Make functions on timeline tree view point to the right source location

DevTools: Make functions on timeline tree view point to the right source location

BUG=526332
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201581

[alph, 2015-08-29 00:24:04]

alph@chromium.org changed reviewers:
+ caseq@chromium.org, yurys@chromium.org

[pfeldman, 2015-08-29 00:40:45]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2015-08-29 00:40:45]

https://codereview.chromium.org/1312903005/diff/1/Source/devtools/front_end/t...
File Source/devtools/front_end/timeline/TimelineTreeView.js (right):

https://codereview.chromium.org/1312903005/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineTreeView.js:16: this._linkifier = new
WebInspector.Linkifier();
You need to reset the linkifier upon dispose.

[yurys, 2015-08-29 00:44:18]

https://codereview.chromium.org/1312903005/diff/1/Source/devtools/front_end/t...
File Source/devtools/front_end/timeline/TimelineModel.js (right):

https://codereview.chromium.org/1312903005/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineModel.js:1487: for (var i = 0, l =
filters.length; i < l; ++i) {
did it prove to be slow?

https://codereview.chromium.org/1312903005/diff/1/Source/devtools/front_end/t...
File Source/devtools/front_end/timeline/TimelineTreeView.js (right):

https://codereview.chromium.org/1312903005/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineTreeView.js:405: var lineNumber =
frame && frame["lineNumber"] || 0;
Don't we start line numbering from 1 in the UI?

https://codereview.chromium.org/1312903005/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineTreeView.js:408:
link.appendChild(this._treeView.linkifyLocation(scriptId, url, lineNumber,
columnNumber));
When do you clear the linkifier?

[alph, 2015-09-01 21:38:55]

ptal

https://codereview.chromium.org/1312903005/diff/1/Source/devtools/front_end/t...
File Source/devtools/front_end/timeline/TimelineModel.js (right):

https://codereview.chromium.org/1312903005/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineModel.js:1487: for (var i = 0, l =
filters.length; i < l; ++i) {
On 2015/08/29 00:44:18, yurys wrote:
> did it prove to be slow?

Yes, for-of still disables optimization and the filter function is very hot.

https://codereview.chromium.org/1312903005/diff/1/Source/devtools/front_end/t...
File Source/devtools/front_end/timeline/TimelineTreeView.js (right):

https://codereview.chromium.org/1312903005/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineTreeView.js:16: this._linkifier = new
WebInspector.Linkifier();
On 2015/08/29 00:40:45, pfeldman wrote:
> You need to reset the linkifier upon dispose.

The tree view is never disposed. Added reset on tree view updates data.

https://codereview.chromium.org/1312903005/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineTreeView.js:405: var lineNumber =
frame && frame["lineNumber"] || 0;
On 2015/08/29 00:44:18, yurys wrote:
> Don't we start line numbering from 1 in the UI?

Done.

https://codereview.chromium.org/1312903005/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineTreeView.js:408:
link.appendChild(this._treeView.linkifyLocation(scriptId, url, lineNumber,
columnNumber));
On 2015/08/29 00:44:18, yurys wrote:
> When do you clear the linkifier?

Added reset on tree repopulate.

[yurys, 2015-09-01 21:48:51]

lgtm

[alph, 2015-09-01 21:53:02]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2015-09-01 21:53:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312903005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312903005/20001

[alph, 2015-09-01 22:42:17]

The CQ bit was unchecked by alph@chromium.org

[alph, 2015-09-01 22:42:19]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2015-09-01 22:42:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312903005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312903005/20001

[commit-bot: I haz the power, 2015-09-01 23:08:36]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201581