Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: src/compiler/access-builder.cc

Issue 1312893010: Remove no-zone versions of intersection and union. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/access-builder.h ('k') | src/compiler/js-typed-lowering.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/access-builder.cc
diff --git a/src/compiler/access-builder.cc b/src/compiler/access-builder.cc
index b54982f4c9288e06e6da4af72a97e050d1444851..8a03ff77f38c5964f76e5a7bc73e75958505dbc9 100644
--- a/src/compiler/access-builder.cc
+++ b/src/compiler/access-builder.cc
@@ -67,14 +67,12 @@ FieldAccess AccessBuilder::ForJSDateField(JSDate::FieldIndex index) {
// static
-FieldAccess AccessBuilder::ForFixedArrayLength() {
- // TODO(turbofan): 2^30 is a valid upper limit for the FixedArray::length
- // field, although it's not the best. If we had a Zone we could create an
- // appropriate range type instead.
+FieldAccess AccessBuilder::ForFixedArrayLength(Zone* zone) {
STATIC_ASSERT(FixedArray::kMaxLength <= 1 << 30);
FieldAccess access = {
kTaggedBase, FixedArray::kLengthOffset, MaybeHandle<Name>(),
- Type::Intersect(Type::Unsigned30(), Type::TaggedSigned()),
+ Type::Intersect(Type::Range(0, FixedArray::kMaxLength, zone),
+ Type::TaggedSigned(), zone),
kMachAnyTagged};
return access;
}
« no previous file with comments | « src/compiler/access-builder.h ('k') | src/compiler/js-typed-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698