Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Side by Side Diff: src/compiler/verifier.cc

Issue 1312893010: Remove no-zone versions of intersection and union. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | src/interface-descriptors.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 573 matching lines...) Expand 10 before | Expand all | Expand 10 after
584 CheckUpperIs(node, Type::Any()); 584 CheckUpperIs(node, Type::Any());
585 break; 585 break;
586 } 586 }
587 case IrOpcode::kJSForInDone: { 587 case IrOpcode::kJSForInDone: {
588 // TODO(bmeurer): OSR breaks this invariant, although the node is not user 588 // TODO(bmeurer): OSR breaks this invariant, although the node is not user
589 // visible, so we know it is safe (fullcodegen has an unsigned smi there). 589 // visible, so we know it is safe (fullcodegen has an unsigned smi there).
590 // CheckValueInputIs(node, 0, Type::UnsignedSmall()); 590 // CheckValueInputIs(node, 0, Type::UnsignedSmall());
591 break; 591 break;
592 } 592 }
593 case IrOpcode::kJSForInNext: { 593 case IrOpcode::kJSForInNext: {
594 CheckUpperIs(node, Type::Union(Type::Name(), Type::Undefined())); 594 CheckUpperIs(node, Type::Union(Type::Name(), Type::Undefined(), zone));
595 break; 595 break;
596 } 596 }
597 case IrOpcode::kJSForInStep: { 597 case IrOpcode::kJSForInStep: {
598 // TODO(bmeurer): OSR breaks this invariant, although the node is not user 598 // TODO(bmeurer): OSR breaks this invariant, although the node is not user
599 // visible, so we know it is safe (fullcodegen has an unsigned smi there). 599 // visible, so we know it is safe (fullcodegen has an unsigned smi there).
600 // CheckValueInputIs(node, 0, Type::UnsignedSmall()); 600 // CheckValueInputIs(node, 0, Type::UnsignedSmall());
601 CheckUpperIs(node, Type::UnsignedSmall()); 601 CheckUpperIs(node, Type::UnsignedSmall());
602 break; 602 break;
603 } 603 }
604 604
(...skipping 544 matching lines...) Expand 10 before | Expand all | Expand 10 after
1149 // Check inputs for all nodes in the block. 1149 // Check inputs for all nodes in the block.
1150 for (size_t i = 0; i < block->NodeCount(); i++) { 1150 for (size_t i = 0; i < block->NodeCount(); i++) {
1151 Node* node = block->NodeAt(i); 1151 Node* node = block->NodeAt(i);
1152 CheckInputsDominate(schedule, block, node, static_cast<int>(i) - 1); 1152 CheckInputsDominate(schedule, block, node, static_cast<int>(i) - 1);
1153 } 1153 }
1154 } 1154 }
1155 } 1155 }
1156 } // namespace compiler 1156 } // namespace compiler
1157 } // namespace internal 1157 } // namespace internal
1158 } // namespace v8 1158 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | src/interface-descriptors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698